From: Wu Bo <wubo40@huawei.com>
To: <viro@zeniv.linux.org.uk>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linfeilong@huawei.com>, <wubo40@huawei.com>
Subject: [PATCH] fs: direct-io: use DIV_ROUND_UP helper macro for calculations
Date: Mon, 8 Nov 2021 11:10:11 +0800 [thread overview]
Message-ID: <1636341011-6494-1-git-send-email-wubo40@huawei.com> (raw)
Replace open coded divisor calculations with the DIV_ROUND_UP kernel
macro for better readability.
Signed-off-by: Wu Bo <wubo40@huawei.com>
---
fs/direct-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/direct-io.c b/fs/direct-io.c
index 6544435..e5869c2 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -194,7 +194,7 @@ static inline int dio_refill_pages(struct dio *dio, struct dio_submit *sdio)
iov_iter_advance(sdio->iter, ret);
ret += sdio->from;
sdio->head = 0;
- sdio->tail = (ret + PAGE_SIZE - 1) / PAGE_SIZE;
+ sdio->tail = DIV_ROUND_UP(ret, PAGE_SIZE);
sdio->to = ((ret - 1) & (PAGE_SIZE - 1)) + 1;
return 0;
}
--
2.29.2
next reply other threads:[~2021-11-08 2:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 3:10 Wu Bo [this message]
2021-11-08 3:17 ` Joe Perches
2021-11-08 3:52 ` Matthew Wilcox
2021-11-08 4:02 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1636341011-6494-1-git-send-email-wubo40@huawei.com \
--to=wubo40@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®