mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: George Kennedy <george.kennedy@oracle.com>
To: gregkh@linuxfoundation.org, axboe@kernel.dk, asml.silence@gmail.com
Cc: george.kennedy@oracle.com, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] Revert "block: add single bio async direct IO helper" to avoid UAF
Date: Tue,  7 Dec 2021 10:51:40 -0500	[thread overview]
Message-ID: <1638892302-14475-1-git-send-email-george.kennedy@oracle.com> (raw)

git bisect shows that commit 54a88eb838d3
("block: add single bio async direct IO helper")
causes the following UAF: KASAN: use-after-free Write in io_submit_one

Tried to root-cause the issue, but need the patch submitter's help in
coming up with a fix.

Needed to revert commit 1bb6b8102945
("block: avoid extra iter advance with async iocb")
in order to be able to revert 54a88eb838d37af930c9f19e1930a4fba6789cb5.

George Kennedy (2):
  Revert "block: avoid extra iter advance with async iocb"
  Revert "block: add single bio async direct IO helper"

 block/bio.c         |  2 +-
 block/fops.c        | 96 ++---------------------------------------------------
 include/linux/bio.h |  1 -
 3 files changed, 4 insertions(+), 95 deletions(-)

-- 
1.8.3.1


             reply	other threads:[~2021-12-07 15:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07 15:51 George Kennedy [this message]
2021-12-07 15:51 ` [PATCH 1/2] Revert "block: avoid extra iter advance with async iocb" George Kennedy
2021-12-07 15:51 ` [PATCH 2/2] Revert "block: add single bio async direct IO helper" George Kennedy
2021-12-07 17:36 ` [PATCH 0/2] Revert "block: add single bio async direct IO helper" to avoid UAF Pavel Begunkov
2021-12-07 18:09   ` George Kennedy
2021-12-07 18:11     ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1638892302-14475-1-git-send-email-george.kennedy@oracle.com \
    --to=george.kennedy@oracle.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®