From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D84BFCDB46E for ; Thu, 12 Oct 2023 19:17:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442105AbjJLTR5 (ORCPT ); Thu, 12 Oct 2023 15:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379624AbjJLTRz (ORCPT ); Thu, 12 Oct 2023 15:17:55 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2018EC0 for ; Thu, 12 Oct 2023 12:17:54 -0700 (PDT) Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 57FB56607358; Thu, 12 Oct 2023 20:17:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1697138272; bh=XOvQRewMR/StJ5ta/O6p+3WXsHfd+0zrsVXkYfFjTcM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UkH0ypqERYp2FTBmpVNn7AWMLkLVVqgPpwlTm/3eoByGZzH137ghgNGk/8md/dc73 0Ks8BauDyDFw9eUkEDBetdowuFH8BD9ALURwE5EPwXSFKlI83oXESWupYxy9WiPggj zV784MHq1fhA70jD5E+V9N2flsAy96lg8zJPCnRi4/gvVGLlHr7MPnyYEekRMaHM0v 9wU7A5u6HkuvsDFmIbeOZ3B4FUx+P8oXwthgGwSNP1P0gko/9sFetdg6Gg+8OalEfm WEcSIltPu6TnaPf3n8O3vlWqjah+6/PBKuWaKM4Wzvp+EU1T+KLT0kYubM05mwTOnB LlGP9eOqME/Bg== Date: Thu, 12 Oct 2023 15:17:46 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: AngeloGioacchino Del Regno Cc: chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, matthias.bgg@gmail.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wenst@chromium.org, kernel@collabora.com, ehristev@collabora.com Subject: Re: [PATCH v11 08/16] drm/mediatek: De-commonize disp_aal/disp_gamma gamma_set functions Message-ID: <1638da95-fd9c-4557-91d9-92bf1b54feaf@notapiano> References: <20231012095736.100784-1-angelogioacchino.delregno@collabora.com> <20231012095736.100784-9-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231012095736.100784-9-angelogioacchino.delregno@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 12, 2023 at 11:57:28AM +0200, AngeloGioacchino Del Regno wrote: > In preparation for adding a 12-bits gamma support for the DISP_GAMMA > IP, remove the mtk_gamma_set_common() function and move the relevant > bits in mtk_gamma_set() for DISP_GAMMA and mtk_aal_gamma_set() for > DISP_AAL: since the latter has no more support for gamma manipulation > (being moved to a different IP) in newer revisions, those functions > are about to diverge and it makes no sense to keep a common one (with > all the complications of passing common data and making exclusions > for device driver data) for just a few bits. > > This commit brings no functional changes. > > Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Nícolas F. R. A. Prado Thanks, Nícolas