From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793984349; b=WcN/g3P0p4lkhfIeNTXoBY4SA/64QOvLjnorUFwdfuknuRtZO9Og9YL4VfwLhmHEjcFl glMfoKYFyXX4YvaQvcDhxWTyDBbdvdnWDkCr88nHOmefcfmro3dE479+aZdG3v4r9rA0o BrPOEENQeHN7Krqzh6ke33Hi30uSZhzzLAR39RoT1WsM+TmrXc+JV1PKi9sorA/zcrU5F rqSd51Qb/wFXl21Dja2pOGR/Ry3Vje5Xsg84IjjNfKn+u0+DS6zlqu6DoQnl2Q+MNTplv KFPJZkqhKrAGIIpvFRqYX7S2d1sGy2fgDiSHgJA28H1NtKubyyh0WVLYb5h7enRT4Jg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793984349; h=DMARC-Filter:Received:Received:DKIM-Signature:Message-ID:Date: MIME-Version:User-Agent:Subject:To:Cc:References:Content-Language: From:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=ne13n2DB/jDf1VtY7sHJ82JPmofZWUZ317tjpSfR3Dw=; b=RiL7cEWpXWlxDn1QQsLmwAGWyqkIWHBr+46/BJZWwg48+hv+u//heWQGx+/4GEMlsuky KiPCfjukmrusY9UiOJKU2gIWBi9zNqi2TzBQ1UaM7QS5TZG5x/BH1x9vvm/6Epg4hDnkD N9RssB8Z8W7dXRmVYghc46Yzcp2WHpd/wcXf0ddmtTjAKlZ6LaydslZbgqfS09WH7ttha 7aKq5b9YdfzI3268bh2L89CS2AODiU0O1TfyExO/FrpyzPrMal133o8gnmorw5TTLu7wa +2qtzMTz4oiupLI1qsYUiIGWHYqCMKpe91QBu4DMSXY6IjwIGmKUNanoxhkRr4KTxbg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=q4f+N3FU; arc=none smtp.remote-ip=217.140.110.172 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 519CB606A326 for ; Fri, 6 Nov 2026 16:59:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 519CB606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=q4f+N3FU Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3632C15A1; Fri, 6 Nov 2026 08:59:05 -0800 (PST) Received: from [10.2.197.99] (ewhatever.cambridge.arm.com [10.2.197.99]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9021D3F673; Fri, 6 Nov 2026 08:59:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1793984348; bh=SwqfUHhYw1QVVQnkFBQI8TJ6m4IcNWWoizO5xgJB1Dg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=q4f+N3FUhY2jtMruQLhFpwiEFK3SxbelCDNVN4G2YY/fb6ecXxSc6URM7pHHITiUD vzDfxnl3mHUL2B1GI+RlxlC1GGJ+hkP8AG2V86+fFw+S4UmIwq0RrayGh92NCNyHWW //hJqQ1UHYuWPd1hVksWZ4l/ZpM+PYIgyL5FGJ+o= Message-ID: <1639d961-1092-4a47-8825-55c1647a115b@arm.com> Date: Fri, 6 Nov 2026 16:59:05 +0000 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v4 1/3] KVM: arm64: Avoid re-testing walk_continue To: Leonardo Bras , Marc Zyngier , Oliver Upton , Fuad Tabba , Joey Gouly , Steffen Eiden , Zenghui Yu , Catalin Marinas , Will Deacon , Mark Rutland , Raghavendra Rao Ananta Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org References: <20261106161240.1345126-1-leo.bras@arm.com> <20261106161240.1345126-2-leo.bras@arm.com> Content-Language: en-US From: Suzuki K Poulose In-Reply-To: <20261106161240.1345126-2-leo.bras@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/11/2026 16:12, Leonardo Bras wrote: > __kvm_pgtable_visit() performs a bunch of calls to > kvm_pgtable_walk_continue() to find out whether the walk can continue > further, and if not, 'goto out', which retests the possibility of > continuing the walk before exiting. > > Given that it's testing the same ret variable again, there is no reason > the result of kvm_pgtable_walk_continue() would have changed since the > previous check. So turn this goto into an early return, simplifying the > code and paving the way for further rework." Looks sensible to me. Reviewed-by: Suzuki K Poulose > > Signed-off-by: Leonardo Bras > --- > arch/arm64/kvm/hyp/pgtable.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index b74dd5ce1efd..7a51f78b6446 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -183,32 +183,32 @@ static inline int __kvm_pgtable_visit(struct kvm_pgtable_walk_data *data, > * Reload the page table after invoking the walker callback for leaf > * entries or after pre-order traversal, to allow the walker to descend > * into a newly installed or replaced table. > */ > if (reload) { > ctx.old = READ_ONCE(*ptep); > table = kvm_pte_table(ctx.old, level); > } > > if (!kvm_pgtable_walk_continue(data->walker, ret)) > - goto out; > + return ret; > > if (!table) { > data->addr = ALIGN_DOWN(data->addr, kvm_granule_size(level)); > data->addr += kvm_granule_size(level); > goto out; > } > > childp = (kvm_pteref_t)kvm_pte_follow(ctx.old, mm_ops); > ret = __kvm_pgtable_walk(data, mm_ops, childp, level + 1); > if (!kvm_pgtable_walk_continue(data->walker, ret)) > - goto out; > + return ret; > > if (ctx.flags & KVM_PGTABLE_WALK_TABLE_POST) > ret = kvm_pgtable_visitor_cb(data, &ctx, KVM_PGTABLE_WALK_TABLE_POST); > > out: > if (kvm_pgtable_walk_continue(data->walker, ret)) > return 0; > > return ret; > }