From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 852CFC4338F for ; Thu, 19 Aug 2021 12:58:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70E6361156 for ; Thu, 19 Aug 2021 12:58:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238389AbhHSM7Y (ORCPT ); Thu, 19 Aug 2021 08:59:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbhHSM7W (ORCPT ); Thu, 19 Aug 2021 08:59:22 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A989C061575 for ; Thu, 19 Aug 2021 05:58:46 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id z20so12736948ejf.5 for ; Thu, 19 Aug 2021 05:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dei5ldbSnuAmJj+eoYruR4aeAYZ4EbbJLELMi4p7lTI=; b=XkkT/XqAUqWQaj5lpIpXSlVZUEzqkkFIgeL5OhjylY6iDEULaq3AKrsvwhBPsRZJsO eLtLSZs2mndaBcNR8NDtoGYBW9VhtI8NJvg/hR8Q28pP+346Zt3JK/9W1KXtVb4GiY1T ScBiNuKChINddmnm2dUiSNGv5A2AL+4j7Ky8EMHj8y5gi3IMpIqKPSwSSOefPdptUiJs 0Rs8tWwJFmsEj3sFuH1OyPJ4hHZWlm6aRToUWJWkGQFgYYbX5iR1NwwLURLenaflzhnd FhENqRMYK2aJw4Z4NWNL5sN9PGcwTeDzxgKoJUPBlnr14SGSQS8i49UlP5p9bEz0MYt6 0zYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dei5ldbSnuAmJj+eoYruR4aeAYZ4EbbJLELMi4p7lTI=; b=hH23j9rFide5J7X9l1IlyTb4Hs/OVCLgZc9uj8Fm+JdkEvh1H3Mv3v0yXSAx6tIVfU 1Mz4TaaWI2g0e2iqR0DalQgMmbN7FSNWT3e0i8CuesWJneMYRLSDBy9pGTwGPjOwaBS+ DQ4ZKUUy8oBnvmPdiQI9JwQv2O2RXJBUV4dPwIVGTSPpm0VcNDe7SSQL6NiSRRt63tza MxHk34woy9dH9tVMiZTSY75to2ufG6q7XhGrKLyd8F22INe8Lt6v0BQhKElTOSPlhiYe uJO3Kd3W1xPRY/afqtWW98R1Os3lsKy3tGLtd+FC5mi+Xp4wEZ7V2ytrE9LSMWSAidvy nvvQ== X-Gm-Message-State: AOAM531zOJCgPHjx7I0keJ5fVSlj1RftaZo4KKQA8LLJTv657vJt9rjW TsRnjua6SkiO3p/2gtxm1Oo= X-Google-Smtp-Source: ABdhPJyQ8Z0kwxKKTLUi+tZ5wfjG/lnPAZNOc3VWUaPbRlubKaezYE3/1wMSfOflW8qQSUZSqktnrQ== X-Received: by 2002:a17:906:d045:: with SMTP id bo5mr15820830ejb.461.1629377925177; Thu, 19 Aug 2021 05:58:45 -0700 (PDT) Received: from localhost.localdomain (host-79-22-100-164.retail.telecomitalia.it. [79.22.100.164]) by smtp.gmail.com with ESMTPSA id s7sm1722713edu.23.2021.08.19.05.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 05:58:44 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg Kroah-Hartman , Larry Finger , Phillip Potter , Aakash Hemadri Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/5] staging: r8188eu: cast to restricted __be32 Date: Thu, 19 Aug 2021 14:58:43 +0200 Message-ID: <1640197.nFQ5q36Eve@localhost.localdomain> In-Reply-To: <602aefc30b0d979dc6e402d52da2f096ea5c67cf.1629360917.git.aakashhemadri123@gmail.com> References: <602aefc30b0d979dc6e402d52da2f096ea5c67cf.1629360917.git.aakashhemadri123@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, August 19, 2021 10:17:54 AM CEST Aakash Hemadri wrote: > Fix sparse warning: > > rtw_br_ext.c:836:54: warning: cast to restricted __be32 > > Unnecessary double cast, remove them. Are you sure that you had a *double* cast? In the line that you changed I see only a cast and a swap (or, better, a potential swap). Regards, Fabio > > Signed-off-by: Aakash Hemadri > --- > drivers/staging/r8188eu/core/rtw_br_ext.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c > index 404fa8904e47..6a0462ce6230 100644 > --- a/drivers/staging/r8188eu/core/rtw_br_ext.c > +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c > @@ -671,7 +671,7 @@ void dhcp_flag_bcast(struct adapter *priv, struct sk_buff *skb) > (udph->dest == __constant_htons(SERVER_PORT))) { /* DHCP request */ > struct dhcpMessage *dhcph = > (struct dhcpMessage *)((size_t)udph + sizeof(struct udphdr)); > - u32 cookie = be32_to_cpu((__be32)dhcph->cookie); > + u32 cookie = dhcph->cookie; > > if (cookie == DHCP_MAGIC) { /* match magic word */ > if (!(dhcph->flags & htons(BROADCAST_FLAG))) { > -- > 2.32.0 > > >