From: Martyn Welch <martyn.welch@collabora.com>
To: Jeff Chen <jeff.chen_1@nxp.com>, linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org,
johannes@sipsolutions.net, francesco@dolcini.it,
tsung-hsien.hsieh@nxp.com, s.hauer@pengutronix.de,
brian.hsu@nxp.com
Subject: Re: [PATCH v5 00/22] wifi: nxpwifi: create nxpwifi to support iw61x
Date: Tue, 7 Oct 2025 17:49:59 +0100 [thread overview]
Message-ID: <164050d7-e0db-4a67-bf47-6d88e80d78ab@collabora.com> (raw)
In-Reply-To: <20250804154018.3563834-1-jeff.chen_1@nxp.com>
On 04/08/2025 16:39, Jeff Chen wrote:
> This series adds a new full-MAC Wi-Fi driver `nxpwifi` to support NXP IW61x
> chip family. These chips are tri-radio single-chip solutions with Wi-Fi 6
> (1x1, 2.4/5 GHz), Bluetooth 5.4, and IEEE 802.15.4. Communication with the
> external host is via SDIO interface. The driver is tested on i.MX8M Mini
> EVK in both STA and AP mode.
>
> This driver is not based on mac80211. It derives from mwifiex, but due to
> significant differences in firmware architecture, host command interface,
> and supported features, it was not feasible to extend mwifiex without risk
> of regressions. Thus, a new driver is introduced. Future NXP Wi-Fi chipsets
> will also be supported under `nxpwifi`.
>
> The driver passes checkpatch. WPA2/WPA3 personal/enterprise is currently
> handled in host via wpa_supplicant/hostapd.
>
> v4 adds support for TWT, monitor mode, WPA3 Enterprise Suite-B, and various
> fixes and improvements. See below for full changelog.
>
This seems to be working well for me, at least for Wifi. I'd like to get
Bluetooth up as well. The bluetooth driver (btnxpuart) doesn't seem
happy loading the bluetooh firmware:
[ 35.930755] Bluetooth: hci0: Request Firmware: nxp/uartspi_n61x_v1.bin.se
[ 37.953107] Bluetooth: hci0: FW Download Complete: 396444 bytes
[ 37.953167] Bluetooth: hci0: Frame reassembly failed (-84)
[ 39.277635] Bluetooth: hci0: Frame reassembly failed (-84)
[ 39.292011] Bluetooth: hci0: Frame reassembly failed (-84)
[ 39.310094] Bluetooth: hci0: Frame reassembly failed (-84)
[ 39.330273] Bluetooth: hci0: Frame reassembly failed (-84)
[ 39.351381] Bluetooth: hci0: Frame reassembly failed (-84)
[ 39.373112] Bluetooth: hci0: Frame reassembly failed (-84)
[ 41.353087] Bluetooth: hci0: Opcode 0x1002 failed: -110
[ 41.358411] Bluetooth: hci0: command 0x1002 tx timeout
I think the "combo" firmware needs to be loaded by the WiFi driver
right? I assume this isn't supported yet?
Martyn
> Data sheet is available at:
> https://www.nxp.com/docs/en/data-sheet/IW612.pdf
>
> Change history:
>
> v5:
> - Fixed build errors introduced in v4.
>
> v4:
> - Added support for TWT (STA mode)
> - Added support for Monitor mode
> - Added support for WPA3 Enterprise Suite-B
> - Bug fix: In BGN/AN HT40 mode, throughput was 50% lower than expected
> - Bug fix: In STA 2.4G HE40 mode, throughput was 80% lower than expected
> - Use wiphy work instead of general workqueue for cfg80211 ops
> - Introduced RCU protection for ba, rx_reorder, and sta_lists
> - Used per-TID spinlock for tx_ba / rx_reorder lists to improve
> concurrency
> - Replaced mutex_lock with wiphy_lock
> - Reverted "use tasklet for Rx" (back to workqueue)
> - Refactored HE capability handling for better clarity and
> maintainability
> - Used standard kernel helpers for MAC address handling
> - Replaced proprietary nxpwifi_ieee80211 with standard ieee80211_mgmt
> structure
> - Used u32_get_bits() for VHT capability field access
> - Replaced LOW_PRIO_TID with TC_PRIO_BESTEFFORT for skb priority
> - Removed static WPA/RSN OUI table; now derived from cipher suite ID
> - Removed redundant helper functions: has_vendor_hdr and has_ieee_hdr
>
> v3:
> - Enable 802.11ax (Wi-Fi 6) for both AP and STA mode.
> - Extend driver verion string with hotfix number.
> - Remove Rx mlme work.
> - Remove all useless check of netif_carrier_ok().
> - Merge decl.h to cfg.h.
> - Remove unnecessary check for wiphy parameters setting.
> - Synchronize following commits from Mwifiex:
> wifi: mwifiex: replace open-coded module_sdio_driver()
> wifi: mwifiex: Fix interface type change
> wifi: mwifiex: Do not return unused priv in mwifiex_get_priv_by_id()
> wifi: mwifiex: increase max_num_akm_suites
> wifi: mwifiex: duplicate static structs used in driver instances
> wifi: mwifiex: keep mwifiex_cfg80211_ops constant
> wifi: mwifiex: Fix uninitialized variable in
> mwifiex_cfg80211_authenticate()
> wifi: mwifiex: remove unnecessary checks for valid priv
> wifi: mwifiex: Fix memcpy() field-spanning write warning in
> mwifiex_cmd_802_11_scan_ext()
> wifi: mwifiex: Use IRQF_NO_AUTOEN flag in request_irq()
>
> v2:
> - Rename ioctl.h and sta_ioctl.c to cfg.h and sta_cfg.c.
> - Remove useless header file semaphore.h.
> - Use static variable for cookie.
> - Modify nxpwifi_register to use ERR_PTR, IS_ERR and PTR_ERR.
> - Use error number for error code.
> - Remove unnecessary private ie definitions.
> - Remove mutex async_mutex and related code.
> - Remove unnecessary work queue.
> - Add the support for PSK SHA256.
> - Use tasklet for Rx.
> - Remove unused functions.
> - Remove compile warning.
>
> Jeff Chen (22):
> wifi: nxpwifi: add 802.11n files
> wifi: nxpwifi: add 802.11ac files
> wifi: nxpwifi: add 802.11ax files
> wifi: nxpwifi: add 802.11h file
> wifi: nxpwifi: add WMM files
> wifi: nxpwifi: add scan.c
> wifi: nxpwifi: add join.c
> wifi: nxpwifi: add cfp.c
> wifi: nxpwifi: add configuration files
> wifi: nxpwifi: implement cfg80211 ops
> wifi: nxpwifi: add host command file
> wifi: nxpwifi: add command and event files
> wifi: nxpwifi: add data path files
> wifi: nxpwifi: add debugfs file
> wifi: nxpwifi: add ethtool.c
> wifi: nxpwifi: add utility files
> wifi: nxpwifi: add initialization file
> wifi: nxpwifi: add core files
> wifi: nxpwifi: add sdio bus driver files
> wifi: nxpwifi: modify sdio_ids.h
> wifi: nxpwifi: add makefile and kconfig files
> wifi: nxpwifi: modify MAINTAINERS file
>
> MAINTAINERS | 9 +
> drivers/net/wireless/Kconfig | 1 +
> drivers/net/wireless/Makefile | 1 +
> drivers/net/wireless/nxp/Kconfig | 17 +
> drivers/net/wireless/nxp/Makefile | 3 +
> drivers/net/wireless/nxp/nxpwifi/11ac.c | 289 ++
> drivers/net/wireless/nxp/nxpwifi/11ac.h | 32 +
> drivers/net/wireless/nxp/nxpwifi/11ax.c | 590 +++
> drivers/net/wireless/nxp/nxpwifi/11ax.h | 72 +
> drivers/net/wireless/nxp/nxpwifi/11h.c | 346 ++
> drivers/net/wireless/nxp/nxpwifi/11n.c | 895 ++++
> drivers/net/wireless/nxp/nxpwifi/11n.h | 167 +
> drivers/net/wireless/nxp/nxpwifi/11n_aggr.c | 275 ++
> drivers/net/wireless/nxp/nxpwifi/11n_aggr.h | 21 +
> .../net/wireless/nxp/nxpwifi/11n_rxreorder.c | 938 ++++
> .../net/wireless/nxp/nxpwifi/11n_rxreorder.h | 71 +
> drivers/net/wireless/nxp/nxpwifi/Kconfig | 22 +
> drivers/net/wireless/nxp/nxpwifi/Makefile | 39 +
> drivers/net/wireless/nxp/nxpwifi/cfg.h | 984 ++++
> drivers/net/wireless/nxp/nxpwifi/cfg80211.c | 4071 +++++++++++++++++
> drivers/net/wireless/nxp/nxpwifi/cfg80211.h | 19 +
> drivers/net/wireless/nxp/nxpwifi/cfp.c | 475 ++
> drivers/net/wireless/nxp/nxpwifi/cmdevt.c | 1284 ++++++
> drivers/net/wireless/nxp/nxpwifi/cmdevt.h | 98 +
> drivers/net/wireless/nxp/nxpwifi/debugfs.c | 1230 +++++
> drivers/net/wireless/nxp/nxpwifi/ethtool.c | 58 +
> drivers/net/wireless/nxp/nxpwifi/fw.h | 2401 ++++++++++
> drivers/net/wireless/nxp/nxpwifi/ie.c | 501 ++
> drivers/net/wireless/nxp/nxpwifi/init.c | 684 +++
> drivers/net/wireless/nxp/nxpwifi/join.c | 911 ++++
> drivers/net/wireless/nxp/nxpwifi/main.c | 1716 +++++++
> drivers/net/wireless/nxp/nxpwifi/main.h | 1850 ++++++++
> drivers/net/wireless/nxp/nxpwifi/scan.c | 2805 ++++++++++++
> drivers/net/wireless/nxp/nxpwifi/sdio.c | 2656 +++++++++++
> drivers/net/wireless/nxp/nxpwifi/sdio.h | 340 ++
> drivers/net/wireless/nxp/nxpwifi/sta_cfg.c | 1319 ++++++
> drivers/net/wireless/nxp/nxpwifi/sta_cmd.c | 3449 ++++++++++++++
> drivers/net/wireless/nxp/nxpwifi/sta_event.c | 868 ++++
> drivers/net/wireless/nxp/nxpwifi/sta_rx.c | 250 +
> drivers/net/wireless/nxp/nxpwifi/sta_tx.c | 208 +
> drivers/net/wireless/nxp/nxpwifi/txrx.c | 358 ++
> drivers/net/wireless/nxp/nxpwifi/uap_cmd.c | 1234 +++++
> drivers/net/wireless/nxp/nxpwifi/uap_event.c | 490 ++
> drivers/net/wireless/nxp/nxpwifi/uap_txrx.c | 506 ++
> drivers/net/wireless/nxp/nxpwifi/util.c | 1580 +++++++
> drivers/net/wireless/nxp/nxpwifi/util.h | 132 +
> drivers/net/wireless/nxp/nxpwifi/wmm.c | 1379 ++++++
> drivers/net/wireless/nxp/nxpwifi/wmm.h | 78 +
> include/linux/mmc/sdio_ids.h | 3 +
> 49 files changed, 37725 insertions(+)
> create mode 100644 drivers/net/wireless/nxp/Kconfig
> create mode 100644 drivers/net/wireless/nxp/Makefile
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/11ac.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/11ac.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/11ax.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/11ax.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/11h.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/11n.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/11n.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/11n_aggr.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/11n_aggr.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/11n_rxreorder.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/11n_rxreorder.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/Kconfig
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/Makefile
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/cfg.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/cfg80211.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/cfg80211.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/cfp.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/cmdevt.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/cmdevt.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/debugfs.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/ethtool.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/fw.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/ie.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/init.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/join.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/main.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/main.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/scan.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/sdio.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/sdio.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/sta_cfg.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/sta_cmd.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/sta_event.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/sta_rx.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/sta_tx.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/txrx.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/uap_cmd.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/uap_event.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/uap_txrx.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/util.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/util.h
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/wmm.c
> create mode 100644 drivers/net/wireless/nxp/nxpwifi/wmm.h
>
next prev parent reply other threads:[~2025-10-07 16:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 15:39 Jeff Chen
2025-08-04 15:39 ` [PATCH v5 01/22] wifi: nxpwifi: add 802.11n files Jeff Chen
2025-09-04 11:22 ` Johannes Berg
2025-08-04 15:39 ` [PATCH v5 02/22] wifi: nxpwifi: add 802.11ac files Jeff Chen
2025-08-04 15:39 ` [PATCH v5 03/22] wifi: nxpwifi: add 802.11ax files Jeff Chen
2025-08-04 15:40 ` [PATCH v5 04/22] wifi: nxpwifi: add 802.11h file Jeff Chen
2025-08-04 15:40 ` [PATCH v5 05/22] wifi: nxpwifi: add WMM files Jeff Chen
2025-08-04 15:40 ` [PATCH v5 06/22] wifi: nxpwifi: add scan.c Jeff Chen
2025-08-04 15:40 ` [PATCH v5 07/22] wifi: nxpwifi: add join.c Jeff Chen
2025-08-04 15:40 ` [PATCH v5 08/22] wifi: nxpwifi: add cfp.c Jeff Chen
2025-08-04 15:40 ` [PATCH v5 09/22] wifi: nxpwifi: add configuration files Jeff Chen
2025-08-04 15:40 ` [PATCH v5 10/22] wifi: nxpwifi: implement cfg80211 ops Jeff Chen
2025-08-04 15:40 ` [PATCH v5 11/22] wifi: nxpwifi: add host command file Jeff Chen
2025-08-04 15:40 ` [PATCH v5 12/22] wifi: nxpwifi: add command and event files Jeff Chen
2025-08-04 15:40 ` [PATCH v5 13/22] wifi: nxpwifi: add data path files Jeff Chen
2025-08-04 15:40 ` [PATCH v5 14/22] wifi: nxpwifi: add debugfs file Jeff Chen
2025-08-04 15:40 ` [PATCH v5 15/22] wifi: nxpwifi: add ethtool.c Jeff Chen
2025-08-04 15:40 ` [PATCH v5 16/22] wifi: nxpwifi: add utility files Jeff Chen
2025-08-04 15:40 ` [PATCH v5 17/22] wifi: nxpwifi: add initialization file Jeff Chen
2025-08-04 15:40 ` [PATCH v5 18/22] wifi: nxpwifi: add core files Jeff Chen
2025-09-04 11:37 ` Johannes Berg
2025-09-19 18:06 ` Jeff Chen
2025-10-01 10:17 ` Jeff Chen
2025-10-01 10:19 ` Johannes Berg
2025-08-04 15:40 ` [PATCH v5 19/22] wifi: nxpwifi: add sdio bus driver files Jeff Chen
2025-08-04 15:40 ` [PATCH v5 20/22] wifi: nxpwifi: modify sdio_ids.h Jeff Chen
2025-08-04 15:40 ` [PATCH v5 21/22] wifi: nxpwifi: add makefile and kconfig files Jeff Chen
2025-08-04 15:40 ` [PATCH v5 22/22] wifi: nxpwifi: modify MAINTAINERS file Jeff Chen
2025-09-04 11:39 ` [PATCH v5 00/22] wifi: nxpwifi: create nxpwifi to support iw61x Johannes Berg
2025-10-07 16:49 ` Martyn Welch [this message]
2025-10-09 16:01 ` Jeff Chen
2025-10-10 16:22 ` Martyn Welch
2025-10-13 18:18 ` [EXT] " Jeff Chen
2025-10-14 10:20 ` Martyn Welch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164050d7-e0db-4a67-bf47-6d88e80d78ab@collabora.com \
--to=martyn.welch@collabora.com \
--cc=brian.hsu@nxp.com \
--cc=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=jeff.chen_1@nxp.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tsung-hsien.hsieh@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome