From: Deepak Kumar Singh <quic_deesin@quicinc.com>
To: <bjorn.andersson@linaro.org>, <swboyd@chromium.org>,
<quic_clew@quicinc.com>, <mathieu.poirier@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>,
Deepak Kumar Singh <quic_deesin@quicinc.com>,
Ohad Ben-Cohen <ohad@wizery.com>
Subject: [PATCH V2 3/3] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
Date: Wed, 19 Jan 2022 01:13:13 +0530 [thread overview]
Message-ID: <1642534993-6552-4-git-send-email-quic_deesin@quicinc.com> (raw)
In-Reply-To: <1642534993-6552-1-git-send-email-quic_deesin@quicinc.com>
Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes
to get/set the low level transport signals.
Signed-off-by: Chris Lew <quic_clew@quicinc.com>
Signed-off-by: Deepak Kumar Singh <quic_deesin@quicinc.com>
---
drivers/rpmsg/rpmsg_char.c | 47 ++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 43 insertions(+), 4 deletions(-)
diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
index b5907b8..c03a118 100644
--- a/drivers/rpmsg/rpmsg_char.c
+++ b/drivers/rpmsg/rpmsg_char.c
@@ -19,6 +19,7 @@
#include <linux/rpmsg.h>
#include <linux/skbuff.h>
#include <linux/slab.h>
+#include <linux/termios.h>
#include <linux/uaccess.h>
#include <uapi/linux/rpmsg.h>
@@ -74,6 +75,9 @@ struct rpmsg_eptdev {
spinlock_t queue_lock;
struct sk_buff_head queue;
wait_queue_head_t readq;
+
+ u32 rsigs;
+ bool sig_pending;
};
static int rpmsg_eptdev_destroy(struct device *dev, void *data)
@@ -112,7 +116,18 @@ static int rpmsg_ept_cb(struct rpmsg_device *rpdev, void *buf, int len,
skb_queue_tail(&eptdev->queue, skb);
spin_unlock(&eptdev->queue_lock);
- /* wake up any blocking processes, waiting for new data */
+ wake_up_interruptible(&eptdev->readq);
+
+ return 0;
+}
+
+static int rpmsg_sigs_cb(struct rpmsg_device *rpdev, void *priv, u32 sigs)
+{
+ struct rpmsg_eptdev *eptdev = priv;
+
+ eptdev->rsigs = sigs;
+ eptdev->sig_pending = true;
+
wake_up_interruptible(&eptdev->readq);
return 0;
@@ -137,6 +152,7 @@ static int rpmsg_eptdev_open(struct inode *inode, struct file *filp)
return -EINVAL;
}
+ ept->sig_cb = rpmsg_sigs_cb;
eptdev->ept = ept;
filp->private_data = eptdev;
@@ -155,6 +171,7 @@ static int rpmsg_eptdev_release(struct inode *inode, struct file *filp)
eptdev->ept = NULL;
}
mutex_unlock(&eptdev->ept_lock);
+ eptdev->sig_pending = false;
/* Discard all SKBs */
skb_queue_purge(&eptdev->queue);
@@ -265,6 +282,9 @@ static __poll_t rpmsg_eptdev_poll(struct file *filp, poll_table *wait)
if (!skb_queue_empty(&eptdev->queue))
mask |= EPOLLIN | EPOLLRDNORM;
+ if (eptdev->sig_pending)
+ mask |= EPOLLPRI;
+
mask |= rpmsg_poll(eptdev->ept, filp, wait);
return mask;
@@ -274,11 +294,30 @@ static long rpmsg_eptdev_ioctl(struct file *fp, unsigned int cmd,
unsigned long arg)
{
struct rpmsg_eptdev *eptdev = fp->private_data;
+ bool set;
+ u32 val;
+ int ret;
- if (cmd != RPMSG_DESTROY_EPT_IOCTL)
- return -EINVAL;
+ switch (cmd) {
+ case TIOCMGET:
+ eptdev->sig_pending = false;
+ ret = put_user(eptdev->rsigs, (int __user *)arg);
+ break;
+ case TIOCMSET:
+ ret = get_user(val, (int __user *)arg);
+ if (ret)
+ break;
+ set = (val & TIOCM_DTR) ? true : false;
+ ret = rpmsg_set_flow_control(eptdev->ept, set);
+ break;
+ case RPMSG_DESTROY_EPT_IOCTL:
+ ret = rpmsg_eptdev_destroy(&eptdev->dev, NULL);
+ break;
+ default:
+ ret = -EINVAL;
+ }
- return rpmsg_eptdev_destroy(&eptdev->dev, NULL);
+ return ret;
}
static const struct file_operations rpmsg_eptdev_fops = {
--
2.7.4
next prev parent reply other threads:[~2022-01-18 19:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 19:43 [PATCH V2 0/3] rpmsg and glink signaling API support Deepak Kumar Singh
2022-01-18 19:43 ` [PATCH V2 1/3] rpmsg: core: Add signal " Deepak Kumar Singh
2022-03-11 21:11 ` Bjorn Andersson
2022-03-23 10:57 ` Arnaud POULIQUEN
2022-03-29 11:00 ` Deepak Kumar Singh
2022-04-01 13:23 ` Arnaud POULIQUEN
2022-01-18 19:43 ` [PATCH V2 2/3] rpmsg: glink: Add support to handle signals command Deepak Kumar Singh
2022-03-11 21:09 ` Bjorn Andersson
2022-03-23 7:20 ` Deepak Kumar Singh
2022-04-01 13:27 ` Arnaud POULIQUEN
2022-01-18 19:43 ` Deepak Kumar Singh [this message]
2022-03-23 13:38 ` [PATCH V2 3/3] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support Arnaud POULIQUEN
2022-03-29 12:25 ` Deepak Kumar Singh
2022-04-01 13:54 ` Arnaud POULIQUEN
2022-03-23 10:17 ` [PATCH V2 0/3] rpmsg and glink signaling API support Arnaud POULIQUEN
2022-04-25 8:59 ` Arnaud POULIQUEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1642534993-6552-4-git-send-email-quic_deesin@quicinc.com \
--to=quic_deesin@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=quic_clew@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®