From: Rob Herring <robh@kernel.org>
To: "Martin Povišer" <povik+lin@protonmail.com>
Cc: robh+dt@kernel.org, linux-kernel@vger.kernel.org,
alyssa@rosenzweig.io, mturquette@baylibre.com, sboyd@kernel.org,
linux-clk@vger.kernel.org, kettenis@openbsd.org,
sven@svenpeter.dev, marcan@marcan.st, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: Add Apple NCO
Date: Tue, 18 Jan 2022 20:55:53 -0600 [thread overview]
Message-ID: <1642560953.424905.2537491.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220118191839.64086-2-povik+lin@protonmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
On Tue, 18 Jan 2022 19:21:03 +0000, Martin Povišer wrote:
> The NCO block found on Apple SoCs is a programmable clock generator
> performing fractional division of a high frequency input clock.
>
> Signed-off-by: Martin Povišer <povik+lin@protonmail.com>
> ---
> .../devicetree/bindings/clock/apple,nco.yaml | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/apple,nco.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/clock/apple,nco.yaml:24:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1581480
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-01-19 2:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 19:20 [PATCH v2 0/3] Support for Apple SoCs' NCO blocks Martin Povišer
2022-01-18 19:21 ` [PATCH v2 1/3] dt-bindings: clock: Add Apple NCO Martin Povišer
2022-01-18 22:00 ` Mark Kettenis
2022-01-19 2:55 ` Rob Herring [this message]
2022-01-19 14:01 ` Rob Herring
2022-01-18 19:21 ` [PATCH v2 2/3] clk: clk-apple-nco: Add driver for " Martin Povišer
2022-01-20 5:38 ` Stephen Boyd
2022-01-20 12:11 ` Martin Povišer
2022-01-20 20:59 ` Stephen Boyd
2022-01-18 19:21 ` [PATCH v2 3/3] MAINTAINERS: Add clk-apple-nco under ARM/APPLE MACHINE Martin Povišer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1642560953.424905.2537491.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mturquette@baylibre.com \
--cc=povik+lin@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome