From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Tong Zhang <ztong0001@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@kernel.org>,
linux-kernel@vger.kernel.org
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v1] scsi: myrs: fix crash on error case
Date: Tue, 25 Jan 2022 00:41:31 -0500 [thread overview]
Message-ID: <164308927349.18787.5117723366670318865.b4-ty@oracle.com> (raw)
In-Reply-To: <20220123225717.1069538-1-ztong0001@gmail.com>
On Sun, 23 Jan 2022 14:57:17 -0800, Tong Zhang wrote:
> In myrs_detect(), cs->disable_intr is NULL when privdata->hw_init() fail
> with non-zero. In this case, myrs_cleanup(cs) will call a NULL ptr and
> crash kernel.
>
> [ 1.105606] myrs 0000:00:03.0: Unknown Initialization Error 5A
> [ 1.105872] myrs 0000:00:03.0: Failed to initialize Controller
> [ 1.106082] BUG: kernel NULL pointer dereference, address: 0000000000000000
> [ 1.110774] Call Trace:
> [ 1.110950] myrs_cleanup+0xe4/0x150 [myrs]
> [ 1.111135] myrs_probe.cold+0x91/0x56a [myrs]
> [ 1.111302] ? DAC960_GEM_intr_handler+0x1f0/0x1f0 [myrs]
> [ 1.111500] local_pci_probe+0x48/0x90
>
> [...]
Applied to 5.17/scsi-fixes, thanks!
[1/1] scsi: myrs: fix crash on error case
https://git.kernel.org/mkp/scsi/c/4db09593af0b
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2022-01-25 5:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 22:57 Tong Zhang
2022-01-24 6:49 ` Hannes Reinecke
2022-01-25 5:41 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164308927349.18787.5117723366670318865.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®