From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 187D9C433F5 for ; Mon, 31 Jan 2022 14:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379351AbiAaOOr (ORCPT ); Mon, 31 Jan 2022 09:14:47 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:53060 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346623AbiAaOOo (ORCPT ); Mon, 31 Jan 2022 09:14:44 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 48CD6B82985; Mon, 31 Jan 2022 14:14:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28B83C340EF; Mon, 31 Jan 2022 14:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643638482; bh=Jwzdg3jhNqhksWvoAOfXZTDUHbCt7r7dWEMB/5+WEb4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=khi1WY1hIz6HuXBPUO7Hxyfb9A/gfLwJK2wgyhKyjcCfD8XUlycpXp65+/+0EI+RK efAAUC4dnl+YaY9OyycR6A/0OTvwCdNpCkDxwsfUljSenIFPzV3rXVE4iLlVlzhp6o /JSHVo0/dbKxJm3sTrOavET6LELm9aQFTi+wTEVdr6HhF11y+U/AVs/enDlKPsxc3Y nmcZG5/vgd+KDq7BAXpECM5gSVfULe2zNjd8nzOAzP08DItTQ1HCG58BCHbCS0fDtV 1P6KWikH0WguN4FoSaWV4nhOfth4rrfjnDyO4CkM8GWI/h4G2E9DeUjR813c/PfL3z V/ZaQUtedEjaQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] carl9170: fix missing bit-wise or operator for tx_params From: Kalle Valo In-Reply-To: <20220125004406.344422-1-colin.i.king@gmail.com> References: <20220125004406.344422-1-colin.i.king@gmail.com> To: Colin Ian King Cc: Christian Lamparter , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Stable@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164363847846.10147.1688492518810406694.kvalo@kernel.org> Date: Mon, 31 Jan 2022 14:14:39 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin Ian King wrote: > Currently tx_params is being re-assigned with a new value and the > previous setting IEEE80211_HT_MCS_TX_RX_DIFF is being overwritten. > The assignment operator is incorrect, the original intent was to > bit-wise or the value in. Fix this by replacing the = operator > with |= instead. > > Kudos to Christian Lamparter for suggesting the correct fix. > > Fixes: fe8ee9ad80b2 ("carl9170: mac80211 glue and command interface") > Signed-off-by: Colin Ian King > Cc: > Acked-by: Christian Lamparter > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 02a95374b5ee carl9170: fix missing bit-wise or operator for tx_params -- https://patchwork.kernel.org/project/linux-wireless/patch/20220125004406.344422-1-colin.i.king@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches