From: Kalle Valo <kvalo@kernel.org>
To: Peiwei Hu <jlu.hpw@foxmail.com>
Cc: stas.yakovlev@gmail.com, kvalo@codeaurora.org,
davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, trivial@kernel.org,
Peiwei Hu <jlu.hpw@foxmail.com>
Subject: Re: [PATCH] ipw2100: inproper error handling of ipw2100_pci_init_one
Date: Tue, 1 Feb 2022 12:15:04 +0000 (UTC) [thread overview]
Message-ID: <164371770337.16633.7286807059175242667.kvalo@kernel.org> (raw)
In-Reply-To: <tencent_205AA371C910BBA2CF01B311811ABDF2560A@qq.com>
Peiwei Hu <jlu.hpw@foxmail.com> wrote:
> goto fail instead of returning directly in error exiting
>
> Signed-off-by: Peiwei Hu <jlu.hpw@foxmail.com>
The commit log does not answer to "why?". Also looking at
ipw2100_pci_init_one() I think it would need more cleanup in error
handling, for example pci_ionumap() is called in different order etc.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/tencent_205AA371C910BBA2CF01B311811ABDF2560A@qq.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-02-01 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 9:34 Peiwei Hu
2022-02-01 12:15 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164371770337.16633.7286807059175242667.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=davem@davemloft.net \
--cc=jlu.hpw@foxmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stas.yakovlev@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®