From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261267AbUBTTFl (ORCPT ); Fri, 20 Feb 2004 14:05:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261276AbUBTTFl (ORCPT ); Fri, 20 Feb 2004 14:05:41 -0500 Received: from palrel11.hp.com ([156.153.255.246]:40614 "EHLO palrel11.hp.com") by vger.kernel.org with ESMTP id S261267AbUBTTFd (ORCPT ); Fri, 20 Feb 2004 14:05:33 -0500 From: David Mosberger MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16438.23159.786654.810621@napali.hpl.hp.com> Date: Fri, 20 Feb 2004 11:05:27 -0800 To: "Nguyen, Tom L" Cc: "Andreas Schwab" , , , "Nakajima, Jun" , "Luck, Tony" Subject: RE: [PATCH]2.6.3-rc2 MSI Support for IA64 In-Reply-To: References: X-Mailer: VM 7.18 under Emacs 21.3.1 Reply-To: davidm@hpl.hp.com X-URL: http://www.hpl.hp.com/personal/David_Mosberger/ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org >>>>> On Fri, 20 Feb 2004 10:36:12 -0800, "Nguyen, Tom L" said: Tom> To avoid some #ifdef statements as possible, "ia64_platform" Tom> defined in the header file "msi.h" is set to TRUE only if Tom> setting CONFIG_IA64 to 'Y'. The setting of ia64_platform Tom> to TRUE will execute function ia64_alloc_vector. Tom> This API is only used in assign_msi_vector()in msi.c: Tom> vector = (ia64_platform ? ia64_alloc_vector() : assign_irq_vector(MSI_AUTO)); Surely this can be abstracted properly? --david