From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDEA3C433EF for ; Tue, 8 Feb 2022 13:55:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377052AbiBHNz5 (ORCPT ); Tue, 8 Feb 2022 08:55:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357832AbiBHNzz (ORCPT ); Tue, 8 Feb 2022 08:55:55 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77BA8C03FED2 for ; Tue, 8 Feb 2022 05:55:55 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id 10so5974650plj.1 for ; Tue, 08 Feb 2022 05:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=EKe2FDok1vDN1Qrt/TFEsKKKayW/IcHkTy7KAKgN/N0=; b=aB1bmi6XBYOafm4v7Xv9tBP6s3rEWBH814Hppn28SZTw96W7/6XPYpB3DaepS3Qv0z v+rIs0ASLGZsKClVHjUZrYGZ2ZDAR9P07XR4HREpDibXv6mYoihl2c0wMTqTrUfzUHl+ yAOMy3C/4Sur4vBxKsuvaWM1zKz+zYwvOdoWqSJBiZ0RweofciwIDywcfqgexTWlC4+E A3ffPZqPet+qcE/MtVyk8pf/D5LUrTd5J0Rj6/U6BNxEfyr9zRFdXFhKQ8AdOHW/MPPA A7ajuACR6ruzjUl3v48tHDLtCerb0uc5cSk0cnYA2Nkzfa3PXJWOHYdvdt0HIyX6/u38 nRLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=EKe2FDok1vDN1Qrt/TFEsKKKayW/IcHkTy7KAKgN/N0=; b=RREtGfWo1QxxgpTPX9lVNm+OufvQgUZb4JUcYswo8UKXQERQpHFnrvfjb3jBOVh3+Z JSfQI8w1bd5CB36/04l+HYb+av4JTTvQTlqcOjz2stiptkfNqjHkWe6bnd4rrJz5pCqL zCgjuGD33cmvLds6aYVl6QDujmVrATpHAjrHQUgCwsJxCeQCNhVR5ZUDIVdKSdybOBqh gb3952H5IrnoSLWVdQ/R0wQ0hJQ+RSNRgOkjqH+HezFKzJZBk5EzTBkhEUywYTGnM6ni TTT6v+XVqqvUNOjWEkVV9bi2gfGIaWGEx1AvPD5kvhZjpetrFV0AbvEUPJ9gfS4iSnXi coHQ== X-Gm-Message-State: AOAM531sLMlL6X0QQt3gnt/XEiuLkA0IMGjXrPoxq4vu/GEQnsyVPV8l IdE07ZW/pX8UwFjffCbyeGf3RA== X-Google-Smtp-Source: ABdhPJw2DbY44CxqFKwVzHF8+IqK9tnPQDJOED8fVoUNfNb7vC3e0XwGhEPhYo67xEmA40aK1mlBzA== X-Received: by 2002:a17:902:a509:: with SMTP id s9mr4530771plq.134.1644328554913; Tue, 08 Feb 2022 05:55:54 -0800 (PST) Received: from [192.168.1.116] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id g20sm16741663pfj.196.2022.02.08.05.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 05:55:54 -0800 (PST) From: Jens Axboe To: John Garry Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ming.lei@redhat.com In-Reply-To: <1644322024-105340-1-git-send-email-john.garry@huawei.com> References: <1644322024-105340-1-git-send-email-john.garry@huawei.com> Subject: Re: [PATCH] sbitmap: Delete old sbitmap_queue_get_shallow() Message-Id: <164432855377.112661.15719927048269186816.b4-ty@kernel.dk> Date: Tue, 08 Feb 2022 06:55:53 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Feb 2022 20:07:04 +0800, John Garry wrote: > Since __sbitmap_queue_get_shallow() was introduced in commit c05e66733788 > ("sbitmap: add sbitmap_get_shallow() operation"), it has not been used. > > Delete __sbitmap_queue_get_shallow() and rename public > __sbitmap_queue_get_shallow() -> sbitmap_queue_get_shallow() as it is odd > to have public __foo but no foo at all. > > [...] Applied, thanks! [1/1] sbitmap: Delete old sbitmap_queue_get_shallow() commit: 3f607293b74d6acb06571a774a500143c1f0ed2c Best regards, -- Jens Axboe