From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST
Date: Thu, 1 Feb 2024 21:48:55 +0000 [thread overview]
Message-ID: <16443928-07b3-4271-b36e-c0f26eb3329b@gmail.com> (raw)
In-Reply-To: <87eddwz667.wl-tiwai@suse.de>
On 2/1/24 13:05, Takashi Iwai wrote:
>
> It should rather select instead of depends-on. User can't enable
> CONFIG_SND_PCM explicitly, but it's selected by the top-level
> drivers.
>
> Also, please add Fixes tag. It's a clear regression fix.
>
Alright, I'll send the V2 with suggested changes.
Thank you for the review!
--
Kind regards,
Ivan Orlov
prev parent reply other threads:[~2024-02-01 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 9:46 Ivan Orlov
2024-02-01 13:05 ` Takashi Iwai
2024-02-01 21:48 ` Ivan Orlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16443928-07b3-4271-b36e-c0f26eb3329b@gmail.com \
--to=ivan.orlov0322@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®