mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Zhang Wensheng <zhangwensheng5@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH -next] block: update io_ticks when io hang
Date: Wed, 16 Feb 2022 19:48:17 -0700	[thread overview]
Message-ID: <164506609748.50355.11490091116960287078.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220125091938.1799001-1-zhangwensheng5@huawei.com>

On Tue, 25 Jan 2022 17:19:38 +0800, Zhang Wensheng wrote:
> When the inflight IOs are slow and no new IOs are issued, we expect
> iostat could manifest the IO hang problem. However after
> commit 5b18b5a73760 ("block: delete part_round_stats and switch to less
> precise counting"), io_tick and time_in_queue will not be updated until
> the end of IO, and the avgqu-sz and %util columns of iostat will be zero.
> 
> Because it has using stat.nsecs accumulation to express time_in_queue
> which is not suitable to change, and may %util will express the status
> better when io hang occur. To fix io_ticks, we use update_io_ticks and
> inflight to update io_ticks when diskstats_show and part_stat_show
> been called.
> 
> [...]

Applied, thanks!

[1/1] block: update io_ticks when io hang
      commit: 62847731488f59971413484005a7fb2772cb9249

Best regards,
-- 
Jens Axboe



  parent reply	other threads:[~2022-02-17  2:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  9:19 Zhang Wensheng
     [not found] ` <45c2ae11-c44e-f27d-f029-66efe96b0804@huawei.com>
2022-02-08  2:12   ` zhangwensheng (E)
2022-02-10  3:04     ` zhangwensheng (E)
2022-02-17  2:48 ` Jens Axboe [this message]
     [not found]   ` <1998c61c-c3d9-8050-be43-16aba2d6e09f@huawei.com>
2022-02-17  3:08     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164506609748.50355.11490091116960287078.b4-ty@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhangwensheng5@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®