mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Muhammad Usama Anjum" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: "kernelci.org bot" <bot@kernelci.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/sgx] selftests/x86: Add validity check and allow field splitting
Date: Thu, 17 Feb 2022 20:03:24 -0000	[thread overview]
Message-ID: <164512820484.16921.11445103129239646952.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20220214184109.3739179-2-usama.anjum@collabora.com>

The following commit has been merged into the x86/sgx branch of tip:

Commit-ID:     b06e15ebd5bfb670f93c7f11a29b8299c1178bc6
Gitweb:        https://git.kernel.org/tip/b06e15ebd5bfb670f93c7f11a29b8299c1178bc6
Author:        Muhammad Usama Anjum <usama.anjum@collabora.com>
AuthorDate:    Mon, 14 Feb 2022 23:41:08 +05:00
Committer:     Dave Hansen <dave.hansen@linux.intel.com>
CommitterDate: Thu, 17 Feb 2022 11:55:17 -08:00

selftests/x86: Add validity check and allow field splitting

Add check to test if CC has a string. CC can have multiple sub-strings
like "ccache gcc". Erorr pops up if it is treated as single string and
double quotes are used around it. This can be fixed by removing the
quotes and not treating CC as a single string.

Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detection")
Reported-by: "kernelci.org bot" <bot@kernelci.org>
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Link: https://lkml.kernel.org/r/20220214184109.3739179-2-usama.anjum@collabora.com
---
 tools/testing/selftests/x86/check_cc.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/check_cc.sh b/tools/testing/selftests/x86/check_cc.sh
index 3e2089c..8c669c0 100755
--- a/tools/testing/selftests/x86/check_cc.sh
+++ b/tools/testing/selftests/x86/check_cc.sh
@@ -7,7 +7,7 @@ CC="$1"
 TESTPROG="$2"
 shift 2
 
-if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
+if [ -n "$CC" ] && $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
     echo 1
 else
     echo 0

  parent reply	other threads:[~2022-02-17 20:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-14 18:41 [PATCH V2 0/2] selftests: sgx: Fix build of test_sgx Muhammad Usama Anjum
2022-02-14 18:41 ` [PATCH V2 1/2] selftests: x86: add validity check and allow field splitting Muhammad Usama Anjum
2022-02-14 20:59   ` Shuah Khan
2022-02-17 20:03   ` tip-bot2 for Muhammad Usama Anjum [this message]
2022-02-14 18:41 ` [PATCH V2 2/2] selftests: sgx: Treat CC as one argument Muhammad Usama Anjum
2022-02-14 21:00   ` Shuah Khan
2022-02-17 20:03   ` [tip: x86/sgx] selftests/sgx: " tip-bot2 for Muhammad Usama Anjum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164512820484.16921.11445103129239646952.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=bot@kernelci.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=usama.anjum@collabora.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®