From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932667AbdBHOg5 (ORCPT ); Wed, 8 Feb 2017 09:36:57 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:50348 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932431AbdBHOgx (ORCPT ); Wed, 8 Feb 2017 09:36:53 -0500 X-AuditID: b6c32a2e-f79656d0000012f2-e5-589b297a3b26 From: Bartlomiej Zolnierkiewicz To: Arvind Yadav Cc: tomi.valkeinen@ti.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports. Date: Wed, 08 Feb 2017 15:21:43 +0100 Message-id: <1645625.BTpumnS8aX@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <25198769.WjcufK8OeX@amdc3058> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsWy7bCmlm6V5uwIg0k7LCyu9S5ktjjR94HV 4vKuOWwWs5f0s1isn3+LzYHVY+esu+wex29sZ/L4vEkugDmKyyYlNSezLLVI3y6BK+PAot2M Bbu4Ko5fucTSwLiYo4uRk0NCwETi4JwTjBC2mMSFe+vZuhi5OIQEljJKvPg0nwnCaWeS6DvR zgzTsXHmDjBbSGA5o8S5J9UQ9ldGiTuz5UBsNgEriYntq8CmigjoSGya+RvMZhYokmhYewrM FhbwkJh97CwriM0ioCqx8MVxdhCbV0BT4uH150wgtqiAl8SWfe1gNqeAtsTXhxA2r4CgxI/J 91ggZspL7Ns/lRXC1pE4e2wdI8jREgLt7BInv70AeocDyJGV2HQA6n4Xid8zutkgbGGJV8e3 sEPY0hJ/l96ChsR0RontvyUg5mxmlFi1ewJUkbXE4eMXoZbxSfT+fsIEMZ9XoqNNCKLEQ+Lg 2e9MELajxKQZt6GBuJFRoq1tJ+MERvlZSH6YheSHWUh+WMDIvIpRLLWgODc9tdi0wFivODG3 uDQvXS85P3cTIzhVaOntYPy3wPsQowAHoxIP743EWRFCrIllxZW5hxglOJiVRHijVGdHCPGm JFZWpRblxxeV5qQWH2KU5mBREueNMpgYISSQnliSmp2aWpBaBJNl4uCUamCctHHpWiGrXe9l hL3/aHE8i82/u2ZmjZWewjfpZzHnOMQaKlZs3X/jLu86m8QlnUfeyc5Q+5Eyg3Oh61PnVw1X HwUFLOB9z7Hq/PrHE/0W3Og1OnDZqv64q8i/m9Et2/zmPukzjz1+55fjfnmmiWZd2j5L/pq5 LrRcaNlRxd1z59AaZY861U2iSizFGYmGWsxFxYkAGoKfrhEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t9jAd1KzdkRBi1tlhbXehcyW5zo+8Bq cXnXHDaL2Uv6WSzWz7/F5sDqsXPWXXaP4ze2M3l83iQXwBzlZpORmpiSWqSQmpecn5KZl26r FBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZGaABB+cA92AlfbsEt4wDi3YzFuziqjh+5RJL A+Niji5GTg4JAROJjTN3MEPYYhIX7q1n62Lk4hASWMoo0dt3hwnC+coose/kLyaQKjYBK4mJ 7asYQWwRAR2JTTN/g9nMAkUSG6adYwOxhQU8JGYfO8sKYrMIqEosfHGcHcTmFdCUeHj9Odgc UQEviS372sFsTgFtia8P26GWbWSU+PG9F6pBUOLH5HssEAvkJfbtn8oKYWtJrN95nGkCo8As JGWzkJTNQlK2gJF5FaNEakFyQXFSeq5RXmq5XnFibnFpXrpecn7uJkZw/DyT3sF4eJf7IUYB DkYlHt6KiFkRQqyJZcWVuYcYJTiYlUR4o1RnRwjxpiRWVqUW5ccXleakFh9iNAX6cCKzlGhy PjC280riDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhPLEnNTk0tSC2C6WPi4JRqYOR7+2pPjazt 168Heo6X3Evgy3ezvRpx1n3njkMR2w/ncNl6ymU5TfIL5Ow4Y/Z2X/SvtUfbxK88ut9Y9fX1 cr1LcX/Ld+m9Zb6bGi+zxm2zYIWIf/6vJObiJRP/5V798cZ/ZuenTxed1d/fuBZ7bMEZ3bJt wSI8zVJt2sqdV9krS5T6D+gFeymxFGckGmoxFxUnAgAbCv83tQIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170208142146epcas5p376cc88ebcb22fc3c856906d849d407db X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170203122444epcas2p3e0d5ed32cac85fd86d900a62dbeb03a4 X-RootMTR: 20170203122444epcas2p3e0d5ed32cac85fd86d900a62dbeb03a4 References: <25198769.WjcufK8OeX@amdc3058> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, February 08, 2017 11:25:47 AM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, February 07, 2017 05:41:37 PM Arvind Yadav wrote: > > Hi, > > > > In dss_init_ports, There is no need to add dss_uninit_ports before > > returning. > > Because it's already take care in dss_bind. dss_bind is handling > > dss_uninit_ports in error path. > > It doesn't handle cleanup of partially initialized ports, BTW by "partially initialized ports" here I mean cases like i.e. dpi port fully initialized and sdi one not initialized > please look at the code: > > ... > r = dss_init_ports(pdev); > if (r) > goto err_init_ports; > ... > err_runtime_get: > pm_runtime_disable(&pdev->dev); > dss_uninit_ports(pdev); > err_init_ports: > if (dss.video1_pll) > dss_video_pll_uninit(dss.video1_pll); > ... > > dss_uninit_ports() is not called on partially initialized ditto > ports (when dss_init_ports() returns an error we go straight > into err_init_ports label and skip dss_uninit_ports()) > > > -Arvind > > > > > > On Monday 06 February 2017 08:58 PM, Bartlomiej Zolnierkiewicz wrote: > > > dpi_uninit_port() & sdi_uninit_port() skip not fully > > > initialized port Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics