mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: Anders Roxell <anders.roxell@linaro.org>, mpe@ellerman.id.au
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 2/3] powerpc: fix build errors
Date: Thu, 24 Feb 2022 12:54:54 +1000	[thread overview]
Message-ID: <1645670923.t0z533n7uu.astroid@bobo.none> (raw)
In-Reply-To: <20220223135820.2252470-2-anders.roxell@linaro.org>

Excerpts from Anders Roxell's message of February 23, 2022 11:58 pm:
> Building tinyconfig with gcc (Debian 11.2.0-16) and assembler (Debian
> 2.37.90.20220207) the following build error shows up:
> 
>  {standard input}: Assembler messages:
>  {standard input}:1190: Error: unrecognized opcode: `stbcix'
>  {standard input}:1433: Error: unrecognized opcode: `lwzcix'
>  {standard input}:1453: Error: unrecognized opcode: `stbcix'
>  {standard input}:1460: Error: unrecognized opcode: `stwcix'
>  {standard input}:1596: Error: unrecognized opcode: `stbcix'
>  ...
> 
> Rework to add assembler directives [1] around the instruction. Going
> through the them one by one shows that the changes should be safe.  Like
> __get_user_atomic_128_aligned() is only called in p9_hmi_special_emu(),
> which according to the name is specific to power9.  And __raw_rm_read*()
> are only called in things that are powernv or book3s_hv specific.
> 
> [1] https://sourceware.org/binutils/docs/as/PowerPC_002dPseudo.html#PowerPC_002dPseudo

Thanks for doing this. There is a recent patch committed to binutils to work
around this compiler bug.

https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=cebc89b9328

Not sure on the outlook for GCC fix. Either way unfortunately we have 
toolchains in the wild now that will explode, so we might have to take 
your patches for the time being.

Thanks,
Nick

  parent reply	other threads:[~2022-02-24  2:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 13:58 [PATCH 1/3] powerpc: lib: sstep: fix 'sthcx' instruction Anders Roxell
2022-02-23 13:58 ` [PATCH 2/3] powerpc: fix build errors Anders Roxell
2022-02-23 15:21   ` Segher Boessenkool
2022-02-24  2:54   ` Nicholas Piggin [this message]
2022-02-24  5:05     ` Nicholas Piggin
2022-02-24  8:55       ` Arnd Bergmann
2022-02-24 10:11         ` Nicholas Piggin
2022-02-24 10:20           ` Arnd Bergmann
2022-02-24 11:13             ` Nicholas Piggin
2022-02-24 17:29               ` Segher Boessenkool
2022-02-25  0:23                 ` Nicholas Piggin
2022-02-25 22:28                   ` Segher Boessenkool
2022-02-26  0:07                     ` Nicholas Piggin
2022-02-24 17:12       ` Segher Boessenkool
2022-02-25  0:32         ` Nicholas Piggin
2022-02-25  8:33           ` Arnd Bergmann
2022-02-25 10:51             ` Nicholas Piggin
2022-02-25 22:33           ` Segher Boessenkool
2022-02-24 12:39   ` Michael Ellerman
2022-02-24 16:12     ` Anders Roxell
2022-02-24 17:37     ` Segher Boessenkool
2022-02-23 13:58 ` [PATCH 3/3] powerpc: lib: sstep: " Anders Roxell
2022-02-23 15:27   ` Segher Boessenkool
2022-02-24  2:40 ` [PATCH 1/3] powerpc: lib: sstep: fix 'sthcx' instruction Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1645670923.t0z533n7uu.astroid@bobo.none \
    --to=npiggin@gmail.com \
    --cc=anders.roxell@linaro.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®