From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7DF7C433EF for ; Thu, 24 Feb 2022 22:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235840AbiBXW7e (ORCPT ); Thu, 24 Feb 2022 17:59:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232548AbiBXW72 (ORCPT ); Thu, 24 Feb 2022 17:59:28 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1821F1795C2; Thu, 24 Feb 2022 14:58:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AB3EA617FB; Thu, 24 Feb 2022 22:58:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E197C340E9; Thu, 24 Feb 2022 22:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645743537; bh=gYd1RTI9rJtBrwrtL9+aQ/yOPEmRInBZHf3X2dw7+Sc=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=DPduJ6jHZFqExPfWuPOkfbvB0jKRRXRsPAkkrdy+OqKcigkwTDhqDWgi48aPs8T8k R1KwnYFHsieJH+Rqu7Ue9jztoJOEalYCOVcWQ9q1c0w0G8gEqcfwY+/7zTNmEkl7h1 fl4aGHwgGWHF7TaRMPMzScCq/SEHRNmhv1gZXl5/+mlfCr9Gk9GStz4NCpnpOsMSoI FOowQv6QjfLlUIe2A1WYbBCFdrOXgL8XO0ukkG9xoCEY3YWOBC2IqWGzFO+HlF8835 fWGv1lywrgUWZzaf07h3RPsMCHUdQcNQlahogBhk3ODCQoYyW85JgZx0ECZ4ylNNre wyJqGpFdOeqBg== From: Mark Brown To: Ammar Faizi Cc: Keyon Jie , stable@vger.kernel.org, Peter Ujfalusi , alsa-devel@alsa-project.org, Rander Wang , Jaroslav Kysela , Ranjani Sridharan , Daniel Baluta , Pierre-Louis Bossart , sound-open-firmware@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Kai Vehmanen , Liam Girdwood In-Reply-To: <20220224185836.44907-1-ammarfaizi2@gnuweeb.org> References: <20220224145124.15985-1-ammarfaizi2@gnuweeb.org> <04e79b9c-ccb1-119a-c2e2-34c8ca336215@linux.intel.com> <20220224180850.34592-1-ammarfaizi2@gnuweeb.org> <20220224182818.40301-1-ammarfaizi2@gnuweeb.org> <20220224185836.44907-1-ammarfaizi2@gnuweeb.org> Subject: Re: [PATCH v4] ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM Message-Id: <164574353404.3982297.17368553261476958555.b4-ty@kernel.org> Date: Thu, 24 Feb 2022 22:58:54 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Feb 2022 01:58:36 +0700, Ammar Faizi wrote: > Do not call snd_dma_free_pages() when snd_dma_alloc_pages() returns > -ENOMEM because it leads to a NULL pointer dereference bug. > > The dmesg says: > > [ T1387] sof-audio-pci-intel-tgl 0000:00:1f.3: error: memory alloc failed: -12 > [ T1387] BUG: kernel NULL pointer dereference, address: 0000000000000000 > [ T1387] #PF: supervisor read access in kernel mode > [ T1387] #PF: error_code(0x0000) - not-present page > [ T1387] PGD 0 P4D 0 > [ T1387] Oops: 0000 [#1] PREEMPT SMP NOPTI > [ T1387] CPU: 6 PID: 1387 Comm: alsa-sink-HDA A Tainted: G W 5.17.0-rc4-superb-owl-00055-g80d47f5de5e3 > [ T1387] Hardware name: HP HP Laptop 14s-dq2xxx/87FD, BIOS F.15 09/15/2021 > [ T1387] RIP: 0010:dma_free_noncontiguous+0x37/0x80 > [ T1387] Code: [... snip ...] > [ T1387] RSP: 0000:ffffc90002b87770 EFLAGS: 00010246 > [ T1387] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 > [ T1387] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff888101db30d0 > [ T1387] RBP: 00000000fffffff4 R08: 0000000000000000 R09: 0000000000000000 > [ T1387] R10: 0000000000000000 R11: ffffc90002b874d0 R12: 0000000000000001 > [ T1387] R13: 0000000000058000 R14: ffff888105260c68 R15: ffff888105260828 > [ T1387] FS: 00007f42e2ffd640(0000) GS:ffff888466b80000(0000) knlGS:0000000000000000 > [ T1387] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ T1387] CR2: 0000000000000000 CR3: 000000014acf0003 CR4: 0000000000770ee0 > [ T1387] PKRU: 55555554 > [ T1387] Call Trace: > [ T1387] > [ T1387] cl_stream_prepare+0x10a/0x120 [snd_sof_intel_hda_common 146addf995b9279ae7f509621078cccbe4f875e1] > [... snip ...] > [ T1387] > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus Thanks! [1/1] ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM commit: b7fb0ae09009d076964afe4c1a2bde1ee2bd88a9 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark