From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E2FAC433F5 for ; Sat, 26 Feb 2022 06:30:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230062AbiBZGau (ORCPT ); Sat, 26 Feb 2022 01:30:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbiBZGaq (ORCPT ); Sat, 26 Feb 2022 01:30:46 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A730E5AA68; Fri, 25 Feb 2022 22:30:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4088260C95; Sat, 26 Feb 2022 06:30:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 912BCC340F3; Sat, 26 Feb 2022 06:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645857011; bh=rEhJL39ym3hsLRvBexO7f7Z8xVF2dwN5wlDy/4XSS8c=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=kBiw43Cw4FxPKCsT/3Y1dGdK+YuZvx6Ia8XS9Gbz90C3tKff8seNXZnoxEEGMy5TK Vxw6xdi3P3rKPj/hhncE1x7/rxgtcGPBRgOFY8XzWkQeKHzdmQNyVs2ExkDDxFun5X r+mtoGw4fZEpU7gIT2ZUqJ7Eg8IpBYD/MyHbXiGPY9PuCjiGPZF+GLHsbtdd3G2j/G KDcWFvWs+3BfETcfz1RwuCeaSVSFcqn+jmWzjKzIS3VfUVfNuk34sq1S0E7QHjvgf7 fYZsqoJStcifc0WclDt5IAEftjYcCWvWKSAg7CKttH6iB79dr54hQku4mH6lMwLugn 7jW5XW5v05Zww== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 72818F03839; Sat, 26 Feb 2022 06:30:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH][next] net: dsa: qca8k: return with -EINVAL on invalid port From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164585701146.29742.17771254320187155029.git-patchwork-notify@kernel.org> Date: Sat, 26 Feb 2022 06:30:11 +0000 References: <20220224220557.147075-1-colin.i.king@gmail.com> In-Reply-To: <20220224220557.147075-1-colin.i.king@gmail.com> To: Colin Ian King Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, nathan@kernel.org, ndesaulniers@google.com, rmk+kernel@armlinux.org.uk, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Thu, 24 Feb 2022 22:05:57 +0000 you wrote: > Currently an invalid port throws a WARN_ON warning however invalid > uninitialized values in reg and cpu_port_index are being used later > on. Fix this by returning -EINVAL for an invalid port value. > > Addresses clang-scan warnings: > drivers/net/dsa/qca8k.c:1981:3: warning: 2nd function call argument is an > uninitialized value [core.CallAndMessage] > drivers/net/dsa/qca8k.c:1999:9: warning: 2nd function call argument is an > uninitialized value [core.CallAndMessage] > > [...] Here is the summary with links: - [next] net: dsa: qca8k: return with -EINVAL on invalid port https://git.kernel.org/netdev/net-next/c/38455fbcc8ec You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html