From: Mark Brown <broonie@kernel.org>
To: Yun Zhou <yun.zhou@windriver.com>
Cc: linux-kernel@vger.kernel.org, ying.xue@windriver.com,
richard.danter@windriver.com, linux-spi@vger.kernel.org
Subject: Re: [v2][PATCH] spi: use specific last_cs instead of last_cs_enable
Date: Mon, 28 Feb 2022 22:00:19 +0000 [thread overview]
Message-ID: <164608561951.2299679.13478091058345926726.b4-ty@kernel.org> (raw)
In-Reply-To: <20220217141234.72737-1-yun.zhou@windriver.com>
On Thu, 17 Feb 2022 22:12:34 +0800, Yun Zhou wrote:
> Commit d40f0b6f2e21 instroduced last_cs_enable to avoid setting
> chipselect if it's not necessary, but it also introduces a bug. The
> chipselect may not be set correctly on multi-device SPI busses. The
> reason is that we can't judge the chipselect by bool last_cs_enable,
> since chipselect may be modified after other devices were accessed.
>
> So we should record the specific state of chipselect in case of
> confusion.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: use specific last_cs instead of last_cs_enable
commit: 6bb477df04366e0f69dd2f49e1ae1099069326bc
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2022-02-28 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 14:12 Yun Zhou
2022-02-25 8:22 ` Yun Zhou
2022-02-25 13:22 ` Mark Brown
2022-02-28 22:00 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164608561951.2299679.13478091058345926726.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=richard.danter@windriver.com \
--cc=ying.xue@windriver.com \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®