From: Bruce Chen <brucechen251@gmail.com>
To: bruce.chen@unisoc.com, rogerq@kernel.org,
myungjoo.ham@samsung.com, cw00.choi@samsung.com,
linux-kernel@vger.kernel.org
Cc: orsonzhai@gmail.com, gengcixi@gmail.com, baolin.wang7@gmail.com,
zhang.lyra@gmail.com
Subject: [PATCH V1] extcon/usb: Remove disable irq operation in system sleep.
Date: Thu, 3 Mar 2022 15:36:03 +0800 [thread overview]
Message-ID: <1646292963-20570-1-git-send-email-brucechen251@gmail.com> (raw)
From: Bruce Chen <bruce.chen@unisoc.com>
If disable vbus/id irq, it will lead to wakeup system fail
in unisoc platform. In unisoc platform, Irq enable and irq
wakeup are the same interrupt line. So remove disable vbus/id
irq operation is a way to solve the issue.
Signed-off-by: Bruce Chen <bruce.chen@unisoc.com>
---
drivers/extcon/extcon-usb-gpio.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index f2b65d9..40d967a 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -226,16 +226,6 @@ static int usb_extcon_suspend(struct device *dev)
}
}
- /*
- * We don't want to process any IRQs after this point
- * as GPIOs used behind I2C subsystem might not be
- * accessible until resume completes. So disable IRQ.
- */
- if (info->id_gpiod)
- disable_irq(info->id_irq);
- if (info->vbus_gpiod)
- disable_irq(info->vbus_irq);
-
if (!device_may_wakeup(dev))
pinctrl_pm_select_sleep_state(dev);
@@ -267,11 +257,6 @@ static int usb_extcon_resume(struct device *dev)
}
}
- if (info->id_gpiod)
- enable_irq(info->id_irq);
- if (info->vbus_gpiod)
- enable_irq(info->vbus_irq);
-
queue_delayed_work(system_power_efficient_wq,
&info->wq_detcable, 0);
--
1.9.1
next reply other threads:[~2022-03-03 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 7:36 Bruce Chen [this message]
2022-03-03 9:20 ` Roger Quadros
2022-03-07 2:49 ` 答复: " 陈建 (Bruce Chen)
2022-03-07 13:21 ` Vignesh Raghavendra
2022-03-11 5:26 ` Chanwoo Choi
2022-03-08 12:22 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1646292963-20570-1-git-send-email-brucechen251@gmail.com \
--to=brucechen251@gmail.com \
--cc=baolin.wang7@gmail.com \
--cc=bruce.chen@unisoc.com \
--cc=cw00.choi@samsung.com \
--cc=gengcixi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=orsonzhai@gmail.com \
--cc=rogerq@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®