mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: perex@perex.cz, Meng Tang <tangmeng@uniontech.com>,
	lgirdwood@gmail.com, tiwai@suse.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: hdac_hda: Avoid unexpected match when pcm_name is "Analog"
Date: Thu, 03 Mar 2022 13:33:11 +0000	[thread overview]
Message-ID: <164631439115.1870788.3267235264627671548.b4-ty@kernel.org> (raw)
In-Reply-To: <20220302094351.3487-1-tangmeng@uniontech.com>

On Wed, 2 Mar 2022 17:43:51 +0800, Meng Tang wrote:
> pcm name can be "Analog" and "Alt Analog", cpcm->name can be
> "Analog Codec DAI" and "Alt Analog Codec DAI". When pcm_name
> is "Analog", "Analog Codec DAI" and "Alt Analog Codec DAI" are
> both satisfy the 'if (strstr(cpcm->name, pcm_name))' condition,
> which may cause the returned cpcm to be "Alt Analog Codec DAI".
> 
> Even if we get the pcm name by id, and "Analog Codec DAI" goes
> into the loop before "Alt Analog Codec DAI", but I still think
> we'd better have multiple insurances against unexpected return
> values. After, we can correctly return the expected result
> even if other relevant places are changed.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: hdac_hda: Avoid unexpected match when pcm_name is "Analog"
      commit: e94769900f4302b4034945e5d9ec8262a2f5e086

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

      reply	other threads:[~2022-03-03 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02  9:43 Meng Tang
2022-03-03 13:33 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164631439115.1870788.3267235264627671548.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tangmeng@uniontech.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®