From: Huaisheng Ye <yehs2007@zoho.com>
To: "\"Jan Kara\"" <jack@suse.cz>
Cc: <linux-nvdimm@lists.01.org>, <dan.j.williams@intel.com>,
<ross.zwisler@linux.intel.com>, <mawilcox@microsoft.com>,
<vishal.l.verma@intel.com>, <dave.jiang@intel.com>,
<schwidefsky@de.ibm.com>, <heiko.carstens@de.ibm.com>,
<viro@zeniv.linux.org.uk>, <martin.petersen@oracle.com>,
<axboe@kernel.dk>, <gregkh@linuxfoundation.org>,
<bart.vanassche@wdc.com>, <jack@suse.com>, <chengnt@lenovo.com>,
<linux-kernel@vger.kernel.org>, <linux-s390@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>,
"\"Huaisheng Ye\"" <yehs1@lenovo.com>,
"\"colyli\"" <colyli@suse.de>
Subject: Re: [PATCH 3/3] fs/dax: Assigning NULL to gfn of dax_direct_access if useless
Date: Wed, 04 Jul 2018 21:07:35 +0800 [thread overview]
Message-ID: <1646567c191.ed8ea5b817045.8715756414911693238@zoho.com> (raw)
In-Reply-To: <20180704113012.trnfzeefao25clri@quack2.suse.cz>
---- On Wed, 04 Jul 2018 19:30:12 +0800 Jan Kara <jack@suse.cz> wrote ----
> On Wed 04-07-18 14:40:58, Huaisheng Ye wrote:
> > From: Huaisheng Ye <yehs1@lenovo.com>
> >
> > Some functions within fs/dax don't need to get gfn from direct_access.
> > Assigning NULL to gfn of dax_direct_access is more intuitive and simple
> > than offering a useless local variable.
> >
> > Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
>
> I like this. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> for the series.
>
> Honza
>
I am so happy you like them, thank you very much.
---
Cheers,
Huaisheng
next prev parent reply other threads:[~2018-07-04 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 6:40 [PATCH 1/3] nvdimm/pmem: check the validity of the pointer pfn Huaisheng Ye
2018-07-04 6:40 ` [PATCH 2/3] drivers/s390/block/dcssblk: " Huaisheng Ye
2018-07-04 6:40 ` [PATCH 3/3] fs/dax: Assigning NULL to gfn of dax_direct_access if useless Huaisheng Ye
2018-07-04 11:30 ` Jan Kara
2018-07-04 13:07 ` Huaisheng Ye [this message]
2018-07-04 14:37 ` Dan Williams
2018-07-04 14:41 ` Dan Williams
2018-07-04 15:35 ` [External] " Huaisheng HS1 Ye
2018-07-04 14:40 ` [PATCH 1/3] nvdimm/pmem: check the validity of the pointer pfn Dan Williams
2018-07-04 15:35 ` [External] " Huaisheng HS1 Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1646567c191.ed8ea5b817045.8715756414911693238@zoho.com \
--to=yehs2007@zoho.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=chengnt@lenovo.com \
--cc=colyli@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-s390@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mawilcox@microsoft.com \
--cc=ross.zwisler@linux.intel.com \
--cc=schwidefsky@de.ibm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.l.verma@intel.com \
--cc=yehs1@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®