mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fenglin Wu <quic_fenglinw@quicinc.com>
To: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<sboyd@kernel.org>
Cc: <collinsd@codeaurora.org>, <subbaram@codeaurora.org>,
	<quic_fenglinw@quicinc.com>, <tglx@linutronix.de>,
	<maz@kernel.org>
Subject: [PATCH v6 02/10] spmi: pmic-arb: handle spurious interrupt
Date: Thu, 17 Mar 2022 14:12:07 +0800	[thread overview]
Message-ID: <1647497535-32151-3-git-send-email-quic_fenglinw@quicinc.com> (raw)
In-Reply-To: <1647497535-32151-1-git-send-email-quic_fenglinw@quicinc.com>

Call handle_bad_irq() when the summary interrupt is fired spuriously.

Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
---
 drivers/spmi/spmi-pmic-arb.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 5a99723..719bd73 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -605,10 +605,11 @@ static void cleanup_irq(struct spmi_pmic_arb *pmic_arb, u16 apid, int id)
 				irq_mask, ppid);
 }
 
-static void periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 apid)
+static int periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 apid)
 {
 	unsigned int irq;
 	u32 status, id;
+	int handled = 0;
 	u8 sid = (pmic_arb->apid_data[apid].ppid >> 8) & 0xF;
 	u8 per = pmic_arb->apid_data[apid].ppid & 0xFF;
 
@@ -623,7 +624,10 @@ static void periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 apid)
 			continue;
 		}
 		generic_handle_irq(irq);
+		handled++;
 	}
+
+	return handled;
 }
 
 static void pmic_arb_chained_irq(struct irq_desc *desc)
@@ -634,7 +638,7 @@ static void pmic_arb_chained_irq(struct irq_desc *desc)
 	int first = pmic_arb->min_apid >> 5;
 	int last = pmic_arb->max_apid >> 5;
 	u8 ee = pmic_arb->ee;
-	u32 status, enable;
+	u32 status, enable, handled = 0;
 	int i, id, apid;
 
 	chained_irq_enter(chip, desc);
@@ -649,10 +653,14 @@ static void pmic_arb_chained_irq(struct irq_desc *desc)
 			enable = readl_relaxed(
 					ver_ops->acc_enable(pmic_arb, apid));
 			if (enable & SPMI_PIC_ACC_ENABLE_BIT)
-				periph_interrupt(pmic_arb, apid);
+				if (periph_interrupt(pmic_arb, apid) != 0)
+					handled++;
 		}
 	}
 
+	if (handled == 0)
+		handle_bad_irq(desc);
+
 	chained_irq_exit(chip, desc);
 }
 
-- 
2.7.4


  parent reply	other threads:[~2022-03-17  6:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17  6:12 [PATCH v6 00/10] A bunch of fix and optimization patches in spmi-pmic-arb.c Fenglin Wu
2022-03-17  6:12 ` [PATCH v6 01/10] spmi: pmic-arb: add a print in cleanup_irq Fenglin Wu
2022-03-17  6:12 ` Fenglin Wu [this message]
2022-03-17  6:12 ` [PATCH v6 03/10] spmi: pmic-arb: do not ack and clear peripheral interrupts " Fenglin Wu
2022-03-17  6:12 ` [PATCH v6 04/10] spmi: pmic-arb: check apid against limits before calling irq handler Fenglin Wu
2022-03-17  6:12 ` [PATCH v6 05/10] spmi: pmic-arb: add support to dispatch interrupt based on IRQ status Fenglin Wu
2022-03-17  6:12 ` [PATCH v6 06/10] spmi: pmic-arb: correct duplicate APID to PPID mapping logic Fenglin Wu
2022-03-17  6:12 ` [PATCH v6 07/10] spmi: pmic-arb: block access for invalid PMIC arbiter v5 SPMI writes Fenglin Wu
2022-03-17  6:12 ` [PATCH v6 08/10] dt-bindings: spmi: spmi-pmic-arb: make interrupt properties as optional Fenglin Wu
2022-03-21 23:29   ` Rob Herring
2022-03-17  6:12 ` [PATCH v6 09/10] spmi: pmic-arb: make interrupt support optional Fenglin Wu
2022-03-17  6:12 ` [PATCH v6 10/10] spmi: pmic-arb: increase SPMI transaction timeout delay Fenglin Wu
2022-04-19 22:34 ` [PATCH v6 00/10] A bunch of fix and optimization patches in spmi-pmic-arb.c Subbaraman Narayanamurthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1647497535-32151-3-git-send-email-quic_fenglinw@quicinc.com \
    --to=quic_fenglinw@quicinc.com \
    --cc=collinsd@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=subbaram@codeaurora.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®