From: Rob Herring <robh@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
ulf.hansson@linaro.org, huziji@marvell.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: xenon: Convert to JSON schema
Date: Sat, 19 Mar 2022 20:13:33 -0600 [thread overview]
Message-ID: <1647742413.974061.2990520.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220318033521.1432767-1-chris.packham@alliedtelesis.co.nz>
On Fri, 18 Mar 2022 16:35:21 +1300, Chris Packham wrote:
> Convert the marvell,xenon-sdhci binding to JSON schema. This is a fairly
> direct conversion so there are some requirements that are documented in
> prose but not currently enforced.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> .../bindings/mmc/marvell,xenon-sdhci.txt | 173 ------------
> .../bindings/mmc/marvell,xenon-sdhci.yaml | 252 ++++++++++++++++++
> 2 files changed, 252 insertions(+), 173 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml:38:13: [warning] wrong indentation: expected 14 but found 12 (indentation)
./Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml:41:13: [warning] wrong indentation: expected 14 but found 12 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
MAINTAINERS: Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt
See https://patchwork.ozlabs.org/patch/1606868
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
prev parent reply other threads:[~2022-03-20 2:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 3:35 Chris Packham
2022-03-18 14:20 ` Krzysztof Kozlowski
2022-03-20 19:51 ` Chris Packham
2022-03-21 8:17 ` Krzysztof Kozlowski
2022-03-21 0:12 ` Chris Packham
2022-03-21 8:18 ` Krzysztof Kozlowski
2022-03-20 2:13 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1647742413.974061.2990520.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=huziji@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®