From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751845AbdCBKYp (ORCPT ); Thu, 2 Mar 2017 05:24:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36160 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbdCBKYn (ORCPT ); Thu, 2 Mar 2017 05:24:43 -0500 Subject: Re: [PATCH 2/2] vfio: type1: conditionally check MSI remapping at irq domain level To: Mian Yousaf Kaukab , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, marc.zyngier@arm.com, alex.williamson@redhat.com References: <20170302100132.20502-1-yousaf.kaukab@suse.com> <20170302100132.20502-2-yousaf.kaukab@suse.com> Cc: will.deacon@arm.com From: Auger Eric Message-ID: <164781c3-af63-b3a1-332f-420b54384b5f@redhat.com> Date: Thu, 2 Mar 2017 11:24:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170302100132.20502-2-yousaf.kaukab@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 02 Mar 2017 10:24:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02/03/2017 11:01, Mian Yousaf Kaukab wrote: > Check only if irq domains are available. > > Signed-off-by: Mian Yousaf Kaukab > --- > drivers/vfio/vfio_iommu_type1.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index bd6f293c4ebd..e3ed50e40ead 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -1287,8 +1287,9 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, > INIT_LIST_HEAD(&domain->group_list); > list_add(&group->next, &domain->group_list); > > - msi_remap = resv_msi ? irq_domain_check_msi_remap() : > - iommu_capable(bus, IOMMU_CAP_INTR_REMAP); > + msi_remap = resv_msi && IS_ENABLED(CONFIG_IRQ_DOMAIN) ? > + irq_domain_check_msi_remap() : > + iommu_capable(bus, IOMMU_CAP_INTR_REMAP); Is that patch actually needed after [PATCH 1/2] irqdomain: add empty irq_domain_check_msi_remap. irq_domain_check_msi_remap() should be defined and if you follow my suggestion, would return false. Anyway in your case resv_msi should be false. Thanks Eric > > if (!allow_unsafe_interrupts && !msi_remap) { > pr_warn("%s: No interrupt remapping support. Use the module param \"allow_unsafe_interrupts\" to enable VFIO IOMMU support on this platform\n", >