mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: trini@kernel.crashing.org
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch 3/22] __early_param for ppc
Date: Thu, 25 Mar 2004 11:59:38 +1100	[thread overview]
Message-ID: <16482.12026.739450.257677@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20040324235747.NSKC2428.fed1mtao03.cox.net@localhost.localdomain>

trini@kernel.crashing.org writes:

> -#ifdef CONFIG_XMON
> -	xmon_map_scc();
> -	if (strstr(cmd_line, "xmon"))
> -		xmon(0);
> -#endif /* CONFIG_XMON */
...
> +/* Allow us a hook to drop in early. */
> +static void __init early_xmon(char **ign)
> +{
> +	xmon_map_scc();
> +	xmon(0);
> +}
> +__early_param("xmon", early_xmon);

You have changed the behaviour here, in that now xmon_map_scc() only
gets called if you put xmon on the command line, whereas previously it
got called unconditionally (assuming CONFIG_XMON=y).  Did you check
whether this will cause problems?

Regards,
Paul.

  reply	other threads:[~2004-03-25  1:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-24 23:57 trini
2004-03-25  0:59 ` Paul Mackerras [this message]
2004-03-25  1:30   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16482.12026.739450.257677@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®