From: QintaoShen <unSimple1993@163.com>
To: linus.walleij@linaro.org
Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org,
yanaijie@huawei.com, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, QintaoShen <unSimple1993@163.com>
Subject: [PATCH v1] pinctrl: ralink: rt2880: Check for return value of devm_kcalloc()
Date: Tue, 29 Mar 2022 15:50:12 +0800 [thread overview]
Message-ID: <1648540212-9790-1-git-send-email-unSimple1993@163.com> (raw)
The memory allocation function devm_kcalloc() may return NULL pointer,
so it is better to add a check for 'p->func[i]->pins' to avoid possible
NULL pointer dereference.
Signed-off-by: QintaoShen <unSimple1993@163.com>
---
drivers/pinctrl/ralink/pinctrl-rt2880.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/pinctrl/ralink/pinctrl-rt2880.c b/drivers/pinctrl/ralink/pinctrl-rt2880.c
index 96fc06d..308610e 100644
--- a/drivers/pinctrl/ralink/pinctrl-rt2880.c
+++ b/drivers/pinctrl/ralink/pinctrl-rt2880.c
@@ -266,6 +266,10 @@ static int rt2880_pinmux_pins(struct rt2880_priv *p)
p->func[i]->pin_count,
sizeof(int),
GFP_KERNEL);
+
+ if (!p->func[i]->pins)
+ continue;
+
for (j = 0; j < p->func[i]->pin_count; j++)
p->func[i]->pins[j] = p->func[i]->pin_first + j;
--
2.7.4
next reply other threads:[~2022-03-29 8:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 7:50 QintaoShen [this message]
2022-03-29 10:34 ` Greg KH
2022-03-29 11:45 ` Andy Shevchenko
[not found] ` <2e3426e0.2d71.17fe315bdb6.Coremail.unsimple1993@163.com>
2022-04-01 9:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1648540212-9790-1-git-send-email-unSimple1993@163.com \
--to=unsimple1993@163.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®