From: Jens Axboe <axboe@kernel.dk>
To: josef@toxicpanda.com, Zhang Wensheng <zhangwensheng5@huawei.com>
Cc: linux-block@vger.kernel.org, nbd@other.debian.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com
Subject: Re: [PATCH -next] nbd: fix possible overflow on 'first_minor' in nbd_dev_add()
Date: Thu, 31 Mar 2022 08:30:44 -0600 [thread overview]
Message-ID: <164873704446.46490.778795283218997371.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220310093224.4002895-1-zhangwensheng5@huawei.com>
On Thu, 10 Mar 2022 17:32:24 +0800, Zhang Wensheng wrote:
> When 'index' is a big numbers, it may become negative which forced
> to 'int'. then 'index << part_shift' might overflow to a positive
> value that is not greater than '0xfffff', then sysfs might complains
> about duplicate creation. Because of this, move the 'index' judgment
> to the front will fix it and be better.
>
>
> [...]
Applied, thanks!
[1/1] nbd: fix possible overflow on 'first_minor' in nbd_dev_add()
commit: 6d35d04a9e18990040e87d2bbf72689252669d54
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2022-03-31 14:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 9:32 Zhang Wensheng
2022-03-11 2:43 ` zhangwensheng (E)
2022-03-17 13:05 ` zhangwensheng (E)
2022-03-31 0:45 ` zhangwensheng (E)
2022-03-31 14:07 ` Josef Bacik
2022-03-31 14:30 ` Jens Axboe [this message]
2022-04-06 11:24 Zhang Wensheng
2022-04-06 12:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164873704446.46490.778795283218997371.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=yukuai3@huawei.com \
--cc=zhangwensheng5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®