From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1606243B48C for ; Mon, 27 Jul 2026 20:41:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184892; cv=none; b=Nti9OSKHtkhd1T/Lfqj1GsxtbZ67OaqsAY3NJOEM59hp65N44uU7Z2kLq5zAubzCl+oUdIB+lHTCoFupCcktF/R/7CyZSqNeoYIhzYkvvVgeEKlq2GEL/hjHUZ8QCUnQ5j+7K62NPm1Jz9f3OUwvzGKICbg1Y9Jv1j3q7A5kEPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184892; c=relaxed/simple; bh=tMRDKtsorJv19qh4QIBQf7AjHv8Uu0NRMvUjf0NFpmQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ITQW6dSJ21xR7TtDsU4WH/yuo5nzmxNnwPgEIFbYhTuVohodS45xRLnP2Ea0yJ3RmyuE5xQ0oBSmb9XJ+tczQYteSJ/T80FVV2YRvFxwjbpOcqGy8s2Q6PVumvK4uHsNH2KWbzYiU+f6jg5oLga3QBOTRgiFu8K9/Tz8QFIT0as= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cte2Gofa; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cte2Gofa" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-84e584c7a5bso1513301b3a.2 for ; Mon, 27 Jul 2026 13:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785184890; x=1785789690; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Uq203R1ZYb1EoosBcCQ2LhjDPAR7gIRz0Ot9zI/XvNU=; b=Cte2GofaPy1ynCY24f73+gmwADoYz9jz9o2jwz9NC6UdhJbVgdmHO0X8aZS4rVZZup N34+ItmnL4fFjAcyiLTFrQTgsP1Ly8ZOaOxJWjsUrCgUGPT/eFPbuy6tLNlBxtSUKiCD nyLKORu58eH+lSre63zKbON9Hu+kfiZGbk2dfwwm+loWGyzN8PxvhYuZbKmwBBxvfQM2 LlxiP90YOqxe7Yw8YSdcV9R/Nk1iRJimU7IOfD2fpj7KQNOTHAcYGDDlNHgdQIANsGQ6 lZHmLBIL9/r5hFyHO/cMz49ztbzvLIgd2N8Mrz5ZQO3QmJK51+4TfV5/YDHMZ4xrJYVo qICQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785184890; x=1785789690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Uq203R1ZYb1EoosBcCQ2LhjDPAR7gIRz0Ot9zI/XvNU=; b=PE22+DRNuMnlcdMeu1JrayER766/fHpN2tqAK6WKyylUDgDXu9NK5sOuxV7Kwo3bqw Nx9y+oTmAeSxjYiHXL1YgYpHIKXAVHhv/i6va5LlwcaXTVwEeLiUQMjhKjsLdUuAMd59 zMdn6sVjTYmKdC6cInpWeXLSJf+gwdNfE890Ii9A55+JDXEpWpQlGuYJgQj7WoqTtVqj 0WZWjmS6QqNZPdOktM2T3rXm89z1Lryokp2jSnMwWmrm6NWBEf7sUeoteaqoMezicVne ru23YqPsT8/taCeCOxHuI0jrKhD9b83S+fzvLCeSPi+R6/GcY43T4jY5l3kFLZeQpIAT 3LMw== X-Forwarded-Encrypted: i=1; AHgh+RoZ0UhK2v1hzTaHXpZ4yvsbKIlOAwyst6bCPUGUTJUc84TfGRYuFE89oNl57czk0lFwKZYOydapwjCKt80=@vger.kernel.org X-Gm-Message-State: AOJu0YwFyOLBrqA/Il4hhEOF8tuxwNUec1NTvcApB1QaF5eLZsJd+nf0 KFlxItO4BpP8xRm0zvsq8UGyrKwhGyj/23FqPhcIsT0lTK3KTenWFBKG X-Gm-Gg: AR+sD121olhJMxFint2+a5sAbZruT7zS35tjfvguegBxvQz4R89ayAHrMVxxq+MARuO bmSazCit7/7HWBlWkmXuVnb+Qo1PCUGu3W7hGz4eFj0NfGUJi/jRiYY4OAiy1tG3RLkgh/O/Ib8 kbUeSlPwtFdvQADCKKpTp0fcompiDqQnSJIB80vwtEbvOKVX8Y1i1JblxBFwzmE/JSwsdy8J1u7 sYE9+k//0bOT3zWWAPy5hvUvCIhsiZedk9NZLQHOQRtdV8dkRDYGpsDFPrqX1qfZeAf8NnmKRG/ Ktgwl7CHRuV5xUrn6iF0oNrApBBs+/eJWgJvDv53KpFNbbKiNVpVJabZSUv6dU40bnHljqCkQE6 8XiUJCG2GzM6RPaZfo8gWbZgzY/1I8zhAfISeZ5FSNrt/hiEjpF7o1PyXHW0c9GOHRxBovdOOaw so2/m1 X-Received: by 2002:a05:6a00:a88e:b0:848:41e1:473c with SMTP id d2e1a72fcca58-84e8d41cd52mr759600b3a.72.1785184890357; Mon, 27 Jul 2026 13:41:30 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fab:e200:3789:64f9:8855:c0af]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e533d1351sm3583338b3a.39.2026.07.27.13.41.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 13:41:29 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Sinan Kaya , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 62/64] dmaengine: hidma: defer callbacks via channel BH Date: Mon, 27 Jul 2026 13:39:24 -0700 Message-ID: <1648cb3a6b6c85009831e1dd263a6336bd31638a.1785183549.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260108080332.2341725-1-allen.lkml@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move descriptor callback processing out of the low-level completion path and schedule it through per-channel BH work. Drain that work while freeing channels so callbacks cannot outlive channel storage. Signed-off-by: Allen Pais --- drivers/dma/qcom/hidma.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index c939635be21d..1f875a499ab3 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -90,7 +90,13 @@ static inline struct hidma_chan *to_hidma_chan(struct dma_chan *dmach) static void hidma_free(struct hidma_dev *dmadev) { - INIT_LIST_HEAD(&dmadev->ddev.channels); + struct hidma_chan *mchan, *next; + + list_for_each_entry_safe(mchan, next, &dmadev->ddev.channels, + chan.device_node) { + dma_chan_kill_bh(&mchan->chan); + list_del(&mchan->chan.device_node); + } } static unsigned int nr_desc_prm; @@ -155,6 +161,13 @@ static void hidma_process_completed(struct hidma_chan *mchan) } } +static void hidma_chan_bh(struct dma_chan *chan) +{ + struct hidma_chan *mchan = to_hidma_chan(chan); + + hidma_process_completed(mchan); +} + /* * Called once for each submitted descriptor. * PM is locked once for each descriptor that is currently @@ -181,7 +194,7 @@ static void hidma_callback(void *data) } spin_unlock_irqrestore(&mchan->lock, irqflags); - hidma_process_completed(mchan); + dma_chan_schedule_bh(&mchan->chan); if (queued) { pm_runtime_mark_last_busy(dmadev->ddev.dev); @@ -203,6 +216,7 @@ static int hidma_chan_init(struct hidma_dev *dmadev, u32 dma_sig) mchan->dmadev = dmadev; mchan->chan.device = ddev; dma_cookie_init(&mchan->chan); + dma_chan_init_bh(&mchan->chan, hidma_chan_bh); INIT_LIST_HEAD(&mchan->free); INIT_LIST_HEAD(&mchan->prepared); -- 2.43.0