From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB6C82C21F1 for ; Fri, 17 Jul 2026 15:23:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784301797; cv=none; b=f5LzFBbSJQX6l3HEv61r5YM2krf9igp3hqp27hYCnzdL2xXs5iEtJY7x4xIcDCcO3xRKSGbWZyxeF9sSOw6zkrXgoO5tV0XTNe+Lh+drPj4QrQVkko7tYpaBPRDCVamjM0oqiK94vL+kxPDTqcQDTQF6UUBaxAwVknkh52gWNTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784301797; c=relaxed/simple; bh=PXO7mXcDt61ktsRe7mrMIbSAZ/ex/y1WeRT/rwpn2TA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=amU9U236mkbLuGVntA93LSeltr6jQMolhiuiPNryjVH+f0KBaplbZiUh8QJaOoStu9oa71tFeQLW+RLUgQLsL2HKgAADg2BmrC2SZ4OBrI0dBvcS6rQuhocZS/Cw1a05LSD1l5aYi/DXQh1LWdtBnyQx0cLfA+WyRINmugbfrCs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JWp6PcNk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ANleDsCu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JWp6PcNk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ANleDsCu" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HE7pbJ1838852 for ; Fri, 17 Jul 2026 15:23:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Kg+DjNoJWRRRaQne0rluuevQFJgkNzMrGtxjrFO36JQ=; b=JWp6PcNkNCnGbC5p 6ZlhQ53/tdiuHSSgP7E9U2cmke6LOok1RO+KLkO5WfgBJgq7dECSQHGU0TRQmtTH QZ4L3gUJ70lG6kt8FIZiPnapSwS78kkqGt8lbP8bI8kb1P00yBwYbB+WIbkyYbB3 MRYNk8r0Fv36FIz6agGaOevGWb2ojofmKtvYvoFOcCsPANZXHLTrc7ONzGxbm+7d xHdcTTjGmmRl0cwUb72l4OaiieFszXFpbMtjYzYE+HJJZsmUCfc0c6cOlB4l9Khh cmld+nrpkLQDtpjiR3gdHRg+m0uFfo0vVBqVjvfmD/2jCDpX8OReHYzDzeWUun2Q xfCtHw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fffag9wsk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 15:23:15 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c15c77619so19530231cf.1 for ; Fri, 17 Jul 2026 08:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784301794; x=1784906594; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Kg+DjNoJWRRRaQne0rluuevQFJgkNzMrGtxjrFO36JQ=; b=ANleDsCuL8j9saSN1lPb+N0OxyqkKjEckeD9zoAzUQ1L/QPYkcKwaLZVGvTp+4M/vi gv6+W1u/l00lAcsa0cuIIw8ruOS6i9P9tDqdchp5Wa2gT1jkjDfc9y8/YPMd4mcBDvaZ wC9/uOCrUJORDfCilRxVcFuJgQg1vtQ57fWid4eHkgTOsahbSs7EtMXf4Xi/6PlWym+8 hYXRgvW4cAdTGl1+k+FclWpCTZhfkvYR1PM0o+5Bsz3tS9EJKLqgAurMjHArmSW3qWSS XIlCVrlXAkojGoYCKKXL31txghCdt0kWqiBzz7wlHgcOqlekBfFPSPLshzc3fkdk0ZrN 7KWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784301794; x=1784906594; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Kg+DjNoJWRRRaQne0rluuevQFJgkNzMrGtxjrFO36JQ=; b=a4jMZ5GokMwXTJkwZMrgfKFyk/Ic/HIAVW+hfBIByH5LqINw5/5A/yz9hteeLvDBya SnYk2Xtw2hIx7Pln3kG+LjabvHHz1EqDQXuHjwHoosExsk36ZEMhLYnS3xuJOTIiXyUu YfjZCfalOimo7ZwrPrCRQxhcTrncmf+AD2drRqoRYnkffW4g+0Vi+h1RkrXrUDepOI2J wwEqk1LZqV9KPlVeEHkCsedkta5/DWyCWhugRlygKUyRsyJ8xo3Oh6KKeM8WdlE8jLOC kGbLdZxQwvOfT8tYZdkzBU1oncYK8CHbSfsMTC6NtRs8jjv0PR8xE9ejCFGCJoHCpW2A qwSg== X-Forwarded-Encrypted: i=1; AHgh+RooK6gXWLI5HkOIh4ZbrbBXPhFL4k/bYAigBh12UFDolZGTl87odAy0/AZdLxO4hIn+CP9jvMp4jENgdzM=@vger.kernel.org X-Gm-Message-State: AOJu0YypoTIyYNVR0ozqHI9mBSqVXAaFTF3UoVnWaLII1zql5W9WlT23 FVvpUwD5PHzjkcLOBEeQ9HTIIuwDMSF8U2M6wMpGiQEgmfFzh9x9+IV/dRVZWyNfc33c429sJfm yGtSZpikkvr6gF7Qb+RDoVgBwU+un36igEIjlzt6V+LX29Mb26WjxdqRh31/mAUWTWzkQ3RtyKK Y= X-Gm-Gg: AfdE7cl+Dw04KSDCVgERutdoQ7uKwZ6JSUKOHhboQbD/Tu4jU6Umj7lB9426f/cZcve 399kURb24mgj36AdkyI8Wv2aofBauHXogLdBOE28nxTFlpjGJQqlkY1/ZpguBDsbC/u1U9eXxdH mGQJm40PFgk1yYFW8a5d8Lac+Ip+J+734fbw5e9aqCCVxYbto3mhZbNZKyblDqob3uwy+oYpTup 4671dJdHm+I5iO2eU7TLQMh2YApVyRf/0bjBDsm8bB/nbm7ebUF9WWLkROa4ycGLaqcW0im+111 Ic3/qQyYg93nZMLfWPV3kFbfX1f6XWm+WESAVmQbNL/Ju1gyUWg9de3UU+zQ8If9h5KixCAZ1Nk Ss5tyBRDk71x8v6k5akOG/kJT X-Received: by 2002:a05:622a:aa43:20b0:50e:6311:7380 with SMTP id d75a77b69052e-5213f861e58mr17403871cf.6.1784301794118; Fri, 17 Jul 2026 08:23:14 -0700 (PDT) X-Received: by 2002:a05:622a:aa43:20b0:50e:6311:7380 with SMTP id d75a77b69052e-5213f861e58mr17403631cf.6.1784301793724; Fri, 17 Jul 2026 08:23:13 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1724f50b83sm93452766b.45.2026.07.17.08.23.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2026 08:23:12 -0700 (PDT) Message-ID: <1648f409-afab-4b2a-907d-a90de62d6bb2@oss.qualcomm.com> Date: Fri, 17 Jul 2026 17:23:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] iommu/qcom: Use devm_pm_runtime_enable() in qcom_iommu_device_probe() To: Mukesh Ojha , Rob Clark , Will Deacon , "Joerg Roedel (AMD)" , Alex Williamson Cc: Robin Murphy , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260717144608.3216274-1-mukesh.ojha@oss.qualcomm.com> <20260717144608.3216274-3-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260717144608.3216274-3-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE1NyBTYWx0ZWRfX7Fbx1o8rmg1p DDJT4Kog0dmJ4hraG/SppKMJwEOL4eZP7q5pN9DEUcfFxJoaA3i95OFj7S9H3vh35hyg+NfaAr/ 74eZvfabqEDDoimE4X9oSSpTVgw9vJDCr6r3B+86zssnQR7OTZtwzIrNExxerjvk9DBcW+ytRTJ ayFwoi28uT2+L60SogRKIdCdRKEET2C5N/8xKopMulQ9IliOjEXrzuItDkOBUlmGQ/jZHgY409r 9TrLGCizqD94wY+g9XgifuEhCQDLi4L6ZTDM7g7x2D1xskljr1HHKMXsHsBRQu40QzPQmWHGtVl 6oEH+abLXd5tauCRJzl1MD4YsRbWGuvBqcwkvVx6NlbEz91FIkBueeYhbo4tHpiwMbkKvieMGAX gFtYhgQaPfAFSOvRLRYRIOeNOQLLVwr2rR4KB4C3lC6AhcNivobm+j4fkkr3wME9fJB4hf/jyF2 tzZQ+V14Zq1KyoCefjg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE1NyBTYWx0ZWRfXwhjrBL0m9BnI DXudHZXFNRp+4N3icZcJzv03JSu1NA/4eztF4+66nCX4Aj+VSuMf8nzpJ7TYjTPLChxGk7g2Afu oqAxt1imbKR85qt2+sgFDry00zhiIVc= X-Authority-Analysis: v=2.4 cv=KZfidwYD c=1 sm=1 tr=0 ts=6a5a48e3 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=xoj3hry2uz_LQgjbiWAA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: InI_X_CeIX3aL7aVMBvYmP1XRt2BjnM_ X-Proofpoint-ORIG-GUID: InI_X_CeIX3aL7aVMBvYmP1XRt2BjnM_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_04,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170157 On 7/17/26 4:46 PM, Mukesh Ojha wrote: > Switch from pm_runtime_enable() to devm_pm_runtime_enable() so that > the matching pm_runtime_disable() is handled automatically via devres, > both on probe failure and on device removal. > > This removes the err_pm_disable error label from the probe function and > the explicit pm_runtime_disable() call from qcom_iommu_device_remove(). > > Signed-off-by: Mukesh Ojha > --- the single-use goto could be inlined now, but anyway Reviewed-by: Konrad Dybcio Konrad