mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: xiam0nd.tong@gmail.com, oder_chiou@realtek.com,
	lgirdwood@gmail.com, tiwai@suse.com, perex@perex.cz
Cc: derek.fang@realtek.com, stable@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] codecs: rt5682: fix an incorrect NULL check on list iterator
Date: Tue, 05 Apr 2022 10:31:18 +0100	[thread overview]
Message-ID: <164915107801.276574.16249779388452959492.b4-ty@kernel.org> (raw)
In-Reply-To: <20220327081002.12684-1-xiam0nd.tong@gmail.com>

On Sun, 27 Mar 2022 16:10:02 +0800, Xiaomeng Tong wrote:
> The bug is here:
> 	if (!dai) {
> 
> The list iterator value 'dai' will *always* be set and non-NULL
> by for_each_component_dais(), so it is incorrect to assume that
> the iterator value will be NULL if the list is empty or no element
> is found (In fact, it will be a bogus pointer to an invalid struct
> object containing the HEAD). Otherwise it will bypass the check
> 'if (!dai) {' (never call dev_err() and never return -ENODEV;)
> and lead to invalid memory access lately when calling
> 'rt5682_set_bclk1_ratio(dai, factor);'.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] codecs: rt5682: fix an incorrect NULL check on list iterator
      commit: c8618d65007ba68d7891130642d73e89372101e8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

      reply	other threads:[~2022-04-05 15:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-27  8:10 Xiaomeng Tong
2022-04-05  9:31 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164915107801.276574.16249779388452959492.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=derek.fang@realtek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=xiam0nd.tong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®