mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Juri Lelli <juri.lelli@redhat.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	Patrick Bellasi <patrick.bellasi@arm.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	Anson Huang <anson.huang@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [BUG] schedutil governor produces regular max freq spikes because of lockup detector watchdog threads
Date: Thu, 11 Jan 2018 02:20:00 +0100	[thread overview]
Message-ID: <16492434.EAxfShfBdI@aspire.rjw.lan> (raw)
In-Reply-To: <20180110142158.GC16413@localhost.localdomain>

On Wednesday, January 10, 2018 3:21:58 PM CET Juri Lelli wrote:
> On 10/01/18 13:35, Rafael J. Wysocki wrote:
> > On Wed, Jan 10, 2018 at 11:54 AM, Juri Lelli <juri.lelli@redhat.com> wrote:
> > > On 09/01/18 16:50, Rafael J. Wysocki wrote:
> > >> On Tue, Jan 9, 2018 at 3:43 PM, Leonard Crestez <leonard.crestez@nxp.com> wrote:
> > >
> > > [...]
> > >
> > >> > Every 4 seconds (really it's /proc/sys/kernel/watchdog_thresh * 2 / 5
> > >> > and watchdog_thresh defaults to 10). There is a per-cpu hrtimer which
> > >> > wakes the per-cpu thread in order to check that tasks can still
> > >> > execute, this works very well against bugs like infinite loops in
> > >> > softirq mode. The timers are synchronized initially but can get
> > >> > staggered (for example by hotplug).
> > >> >
> > >> > My guess is that it's only marked RT so that it executes ahead of other
> > >> > threads and the watchdog doesn't trigger simply when there are lots of
> > >> > userspace tasks.
> > >>
> > >> I think so too.
> > >>
> > >> I see a couple of more-or-less hackish ways to avoid the issue, but
> > >> nothing particularly attractive ATM.
> > >>
> > >> I wouldn't change the general behavior with respect to RT tasks
> > >> because of this, though, as we would quickly find a case in which that
> > >> would turn out to be not desirable.
> > >
> > > I agree we cannot generalize to all RT tasks, but what Patrick proposed
> > > (clamping utilization of certain known tasks) might help here:
> > >
> > > lkml.kernel.org/r/20170824180857.32103-1-patrick.bellasi@arm.com
> > >
> > > Maybe with a per-task interface instead of using cgroups?
> > 
> > The problem here is that this is a kernel thing and user space should
> > not be expected to have to do anything about fixing this IMO.
> 
> Not sure. If we would have such an interface, it should be possible to
> use it from both kernel and userspace.

OK

> In this case kernel might be able
> to do the "right" thing. Also, RT userspace is usually already responsible
> for configuring system priorities, it might be easy to set this as well.
> 
> > > The other option would be to relax DL tasks affinity constraints, so
> > > that a case like this might be handled. Daniel and Tommaso proposed
> > > possible approaches, this might be a driving use case. Not sure how we
> > > would come up with a proper runtime for the watchdog, though.
> > 
> > That is a problem.
> > 
> > Basically, it needs to run as soon as possible, but it will be running
> > for a very short time, every time.
> 
> Does it really require to run "as soon as possible" or is it "at least
> once every watchdog period"? In the latter case DL might still fit, with
> a very short runtime (to be defined).

I guess the latter is closer to what's needed.

> > Overall, using a thread for that seems wasteful ...
> 
> Not sure I'm following you here, aren't we using a thread already?

Yes, we are, which is why I'm wondering if that is the right choice. :-)

Thanks,
Rafael

  reply	other threads:[~2018-01-11  1:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05 20:37 Leonard Crestez
2018-01-05 22:18 ` Rafael J. Wysocki
2018-01-08  4:01   ` Viresh Kumar
2018-01-08 13:10     ` Rafael J. Wysocki
2018-01-08 13:20     ` Leonard Crestez
2018-01-08 15:14       ` Patrick Bellasi
2018-01-08 15:51         ` Leonard Crestez
2018-01-09  1:17           ` Rafael J. Wysocki
2018-01-09 14:43             ` Leonard Crestez
2018-01-09 15:16               ` Lucas Stach
2018-01-09 15:50               ` Rafael J. Wysocki
2018-01-10 10:54                 ` Juri Lelli
2018-01-10 12:35                   ` Rafael J. Wysocki
2018-01-10 14:21                     ` Juri Lelli
2018-01-11  1:20                       ` Rafael J. Wysocki [this message]
2018-01-10  4:08               ` Viresh Kumar
2018-01-06 16:12 Doug Smythies

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16492434.EAxfShfBdI@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=anson.huang@nxp.com \
    --cc=juri.lelli@redhat.com \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=patrick.bellasi@arm.com \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®