From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C38DAC433EF for ; Wed, 6 Apr 2022 15:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235874AbiDFPSq (ORCPT ); Wed, 6 Apr 2022 11:18:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235868AbiDFPQn (ORCPT ); Wed, 6 Apr 2022 11:16:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16694215902; Wed, 6 Apr 2022 05:16:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 86374B82004; Wed, 6 Apr 2022 12:11:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E54D8C385A3; Wed, 6 Apr 2022 12:11:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649247085; bh=gi/43PSg3s+HncWV4pygeyKCzviOExbVIekcbIkX8Eg=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=LF66WlE+eNojHyvhuXfcyptyUC9bV8RwAoGcAAMBUwA/eQHSMwUBqYTFkZpm/A9JB bsSr/KL4JOo4hkRS2ZCFtqB9JC4y2GNGdGRZjTCqTbBolC3t4qjQ4wm3KrBZC5e5bt Mz57FFzXk1mF88JMMPHo+7qi20wmUqncyqIiQqCo6LG2BY42sjz/YlkSkrRlD/NdNk NlQSRO3JU7/KFNHt+vlHZSOIayN6YPDCCvjpuRegxQr6f6b33ssFTx7q0mdEc9J63K XhTXJaYkrKOqLp0r2ysyt0qgTUDxU++/KapRG2oSxUAlXV+1D9InhPKcC7mEBMApxR gMHkcVtoBf1WQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v2] brcmfmac: Avoid keeping power to SDIO card unless WOWL is used From: Kalle Valo In-Reply-To: <20220323083950.414783-1-ulf.hansson@linaro.org> References: <20220323083950.414783-1-ulf.hansson@linaro.org> To: Ulf Hansson Cc: linux-wireless@vger.kernel.org, Yann Gautier , Arend van Spriel , Franky Lin , Hante Meuleman , Gustavo Padovan , Adrian Ratiu , Ulf Hansson , brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164924707922.19026.4759219518482379162.kvalo@kernel.org> Date: Wed, 6 Apr 2022 12:11:22 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ulf Hansson wrote: > Keeping the power to the SDIO card during system wide suspend, consumes > energy. Especially on battery driven embedded systems, this can be a > problem. Therefore, let's change the behaviour into allowing the SDIO card > to be powered off, unless WOWL is supported and enabled. > > Note that, the downside from this change, is that during system resume the > SDIO card needs to be re-initialized and the FW must be re-programmed. Even > if this may take some time to complete, it should we worth it, rather than > draining the battery. > > Signed-off-by: Ulf Hansson > Tested-by: Christophe Roullier > Reviewed-by: Yann Gautier Patch applied to wireless-next.git, thanks. 92cadedd9d5f brcmfmac: Avoid keeping power to SDIO card unless WOWL is used -- https://patchwork.kernel.org/project/linux-wireless/patch/20220323083950.414783-1-ulf.hansson@linaro.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches