mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: matthias.schiffer@ew.tq-group.com
Cc: tudor.ambarus@microchip.com, linux-spi@vger.kernel.org,
	vadivel.muruganx.ramuthevar@linux.intel.com, vigneshr@ti.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: cadence-quadspi: fix protocol setup for non-1-1-X operations
Date: Thu, 07 Apr 2022 18:12:55 +0100	[thread overview]
Message-ID: <164935157541.1057547.6578731972016383100.b4-ty@kernel.org> (raw)
In-Reply-To: <20220331110819.133392-1-matthias.schiffer@ew.tq-group.com>

On Thu, 31 Mar 2022 13:08:19 +0200, Matthias Schiffer wrote:
> cqspi_set_protocol() only set the data width, but ignored the command
> and address width (except for 8-8-8 DTR ops), leading to corruption of
> all transfers using 1-X-X or X-X-X ops. Fix by setting the other two
> widths as well.
> 
> While we're at it, simplify the code a bit by replacing the
> CQSPI_INST_TYPE_* constants with ilog2().
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: cadence-quadspi: fix protocol setup for non-1-1-X operations
      commit: 97e4827d775faa9a32b5e1a97959c69dd77d17a3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

      parent reply	other threads:[~2022-04-07 17:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 11:08 Matthias Schiffer
2022-04-01 10:06 ` Pratyush Yadav
2022-04-01 10:20   ` Matthias Schiffer
2022-04-05 19:37     ` Pratyush Yadav
2022-04-06  8:54       ` Matthias Schiffer
2022-04-07 17:12 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164935157541.1057547.6578731972016383100.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=tudor.ambarus@microchip.com \
    --cc=vadivel.muruganx.ramuthevar@linux.intel.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®