Re: [PATCH v2 1/1] iommu/vtd: Cleanup dma_remapping.h header

[Lu Baolu <baolu.lu@linux.intel.com>]

Hi,

On 11/12/18 3:20 PM, Liu, Yi L wrote:
>> bounces@lists.linux-foundation.org] On Behalf Of Lu Baolu
>> Sent: Monday, November 12, 2018 2:40 PM
>> Subject: [PATCH v2 1/1] iommu/vtd: Cleanup dma_remapping.h header
>>
>> Commit e61d98d8dad00 ("x64, x2apic/intr-remap: Intel vt-d, IOMMU
>> code reorganization") moved dma_remapping.h from drivers/pci/ to
>> current place. It is entirely VT-d specific, but uses a generic
>> name. This merges dma_remapping.h with include/linux/intel-iommu.h
>> and removes dma_remapping.h as the result.
>>
>> Cc: Ashok Raj <ashok.raj@intel.com>
>> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
>> Cc: Sohil Mehta <sohil.mehta@intel.com>
>> Suggested-by: Christoph Hellwig <hch@infradead.org>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> ---
> 
> Reviewed-by: Liu, Yi L <yi.l.liu@intel.com>
> 
> Just out of curious, did you considered to modify the original file
> name to be an intel specific file name? What makes you believe
> merging the file content to intel-iommu.h is better?

I don't think we need multiple headers for VT-d specific things.

Best regards,
Lu Baolu