From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752257AbcFVS2c (ORCPT ); Wed, 22 Jun 2016 14:28:32 -0400 Received: from www.meduna.org ([92.240.244.38]:40480 "EHLO meduna.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbcFVS2b (ORCPT ); Wed, 22 Jun 2016 14:28:31 -0400 X-Greylist: delayed 2637 seconds by postgrey-1.27 at vger.kernel.org; Wed, 22 Jun 2016 14:28:30 EDT From: Stanislav Meduna To: Philipp Zabel , linux-kernel@vger.kernel.org, Dennis Gilmore Subject: Problem with gpu: ipu-v3: Fix imx-ipuv3-crtc module autoloading Message-ID: <164dd12f-cce7-911d-abaa-bf5daab40e6f@meduna.org> Date: Wed, 22 Jun 2016 19:43:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Authenticated-User: stano@meduna.org X-Authenticator: dovecot_plain X-Spam-Score: -2.9 X-Spam-Score-Int: -28 X-Exim-Version: 4.84_2 (build at 13-Mar-2016 22:18:25) X-Date: 2016-06-22 19:54:39 X-Connected-IP: 78.141.77.45:53999 X-Message-Linecount: 79 X-Body-Linecount: 67 X-Message-Size: 2134 X-Body-Size: 1627 X-Received-Count: 1 X-Recipient-Count: 3 X-Local-Recipient-Count: 3 X-Local-Recipient-Defer-Count: 0 X-Local-Recipient-Fail-Count: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, the c04e6e9 patch gpu: ipu-v3: Fix imx-ipuv3-crtc module autoloading broke display connected to a TQMa53 i.MX53 board. The lines imx-drm display-subsystem: bound imx-ipuv3-crtc.0 (ops ipu_crtc_ops) imx-drm display-subsystem: bound imx-ipuv3-crtc.1 (ops ipu_crtc_ops) are not present anymore and the display shows random lines. I am using the 4.4.12-rt19+ kernel with some local changes, but the area of this patch is not touched by either. I am not sure whether my device tree is at fault (I am not an expert here nor did I created the file from scratch) or the patch does not take some special case into account. In any case reverting the patch solves the problem for me. The DTS fragment is disp1: display@disp1 { compatible = "fsl,imx-parallel-display"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_disp1_1>; interface-pix-fmt = "rgb24"; /* * enable this to support parallel display or DVI * disable LVDS bridge and TVE in this case */ status = "okay"; /* * uncomment and adapt to your display to support parallel * LCD display using video mode settings */ display-timings { tx14d11vm1cpd { clock-frequency = <5847953>; hactive = <320>; vactive = <240>; hfront-porch = <30>; hback-porch = <30>; hsync-len = <5>; vback-porch = <5>; vfront-porch = <6>; vsync-len = <2>; pixelclk-active = <1>; hsync-active = <0>; vsync-active = <0>; de-active = <1>; }; }; port { display1_in: endpoint { remote-endpoint = <&ipu_di1_disp1>; }; }; }; Thanks -- Stano