mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
To: <dri-devel@lists.freedesktop.org>,
	<linux-arm-msm@vger.kernel.org>,
	<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>
Cc: Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
	<robdclark@gmail.com>, <seanpaul@chromium.org>,
	<swboyd@chromium.org>, <quic_kalyant@quicinc.com>,
	<quic_abhinavk@quicinc.com>, <dianders@chromium.org>,
	<quic_khsieh@quicinc.com>, <bjorn.andersson@linaro.org>,
	<sean@poorly.run>, <airlied@linux.ie>, <daniel@ffwll.ch>,
	<dmitry.baryshkov@linaro.org>, <quic_vproddut@quicinc.com>,
	<quic_aravindh@quicinc.com>, <steev@kali.org>
Subject: [PATCH v10 4/4] drm/msm/dp: Support the eDP modes given by panel
Date: Mon, 25 Apr 2022 17:14:32 +0530	[thread overview]
Message-ID: <1650887072-16652-5-git-send-email-quic_sbillaka@quicinc.com> (raw)
In-Reply-To: <1650887072-16652-1-git-send-email-quic_sbillaka@quicinc.com>

The eDP controller does not have a reliable way keep panel
powered on to read the sink capabilities. So, the controller
driver cannot validate if a mode can be supported by the
source. We will rely on the panel driver to populate only
the supported modes for now.

Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
Changes in v10:
  - none 

Changes in v9:
  - none

Changes in v8:
  - add the drm/msm/dp tag in the commit title

 drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index fd1dddb9..637fb63 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -998,6 +998,14 @@ enum drm_mode_status dp_bridge_mode_valid(struct drm_bridge *bridge,
 		return -EINVAL;
 	}
 
+	/*
+	 * The eDP controller currently does not have a reliable way of
+	 * enabling panel power to read sink capabilities. So, we rely
+	 * on the panel driver to populate only supported modes for now.
+	 */
+	if (dp->is_edp)
+		return MODE_OK;
+
 	if ((dp->max_pclk_khz <= 0) ||
 			(dp->max_pclk_khz > DP_MAX_PIXEL_CLK_KHZ) ||
 			(mode->clock > dp->max_pclk_khz))
-- 
2.7.4


      parent reply	other threads:[~2022-04-25 11:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 11:44 [PATCH v10 0/4] Add support for the eDP panel over aux_bus Sankeerth Billakanti
2022-04-25 11:44 ` [PATCH v10 1/4] drm/msm/dp: Add eDP support via aux_bus Sankeerth Billakanti
2022-05-06 20:49   ` Dmitry Baryshkov
2022-05-06 21:03     ` Abhinav Kumar
2022-05-06 21:05       ` Dmitry Baryshkov
2022-05-06 21:17         ` [Freedreno] " Abhinav Kumar
2022-05-06 21:17           ` Dmitry Baryshkov
2022-04-25 11:44 ` [PATCH v10 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP Sankeerth Billakanti
2022-04-25 11:44 ` [PATCH v10 3/4] drm/msm/dp: wait for hpd high before aux transaction Sankeerth Billakanti
2022-04-25 11:44 ` Sankeerth Billakanti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1650887072-16652-5-git-send-email-quic_sbillaka@quicinc.com \
    --to=quic_sbillaka@quicinc.com \
    --cc=airlied@linux.ie \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_aravindh@quicinc.com \
    --cc=quic_kalyant@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_vproddut@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=seanpaul@chromium.org \
    --cc=steev@kali.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®