From: David Mosberger <davidm@napali.hpl.hp.com>
To: Jamie Lokier <jamie@shareable.org>
Cc: David Mosberger-Tang <davidm@hpl.hp.com>,
linux-ia64@linuxia64.org, "Siddha,
Suresh B" <suresh.b.siddha@intel.com>,
Andrew Morton <akpm@osdl.org>, Kurt Garloff <garloff@suse.de>,
linux-kernel@vger.kernel.org, mingo@redhat.com
Subject: Re: [PATCH] (IA64) Fix ugly __[PS]* macros in <asm-ia64/pgtable.h>
Date: Wed, 14 Apr 2004 09:07:10 -0700 [thread overview]
Message-ID: <16509.25006.96933.584153@napali.hpl.hp.com> (raw)
In-Reply-To: <20040414113753.GA9413@mail.shareable.org>
Jamie> Patch: ia64-pgtable-2.6.5.patch
Jamie> That mixture of PAGE_* and __pgprot() definitions for the __[PS]*
Jamie> macros in asm-ia64/pgtable.h is really ugly and just makes the code
Jamie> unnecessarily confusing:
Jamie> #define __P000 PAGE_NONE
Jamie> #define __P001 PAGE_READONLY
Jamie> #define __P010 PAGE_READONLY
Jamie> #define __P011 PAGE_READONLY
Jamie> #define __P100 __pgprot(__ACCESS_BITS | _PAGE_PL_3 | _PAGE_AR_X_RX)
Jamie> #define __P101 __pgprot(__ACCESS_BITS | _PAGE_PL_3 | _PAGE_AR_RX)
Jamie> #define __P110 PAGE_COPY
Jamie> #define __P111 PAGE_COPY
Jamie> The PAGE_* macros which are used in __[PS]* aren't used
Jamie> anywhere else: their entire reason for existing is to make the
Jamie> __[PS]* macros clearer. It looks as though the people who
Jamie> implemented the IA-64 port didn't realise that.
Huh? You haven't actually checked, have you?
I don't pollute namespace for no good reason.
Jamie> Here is a page (untested) which cleans up those definitions.
Jamie> It was made from 2.6.5.
If the same names are adopted by the other platforms, I'm fine with it.
Otherwise, see my comment above.
--david
next prev parent reply other threads:[~2004-04-14 16:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 7:28 Non-Exec stack patches Siddha, Suresh B
2004-04-14 8:23 ` Jamie Lokier
2004-04-14 8:35 ` PowerPC exec page protection Jamie Lokier
2004-04-14 8:44 ` Anton Blanchard
2004-04-14 9:35 ` Jamie Lokier
2004-04-14 11:37 ` [PATCH] (IA64) Fix ugly __[PS]* macros in <asm-ia64/pgtable.h> Jamie Lokier
2004-04-14 16:07 ` David Mosberger [this message]
2004-04-14 18:46 ` Jamie Lokier
2004-04-14 19:02 ` David Mosberger
2004-04-14 19:14 ` Jamie Lokier
2004-04-14 19:28 ` Jamie Lokier
2004-04-14 20:05 ` David Mosberger
2004-04-14 21:05 ` Jamie Lokier
2004-04-14 22:34 ` David Mosberger
2004-04-15 15:26 ` Jamie Lokier
2004-04-15 17:45 ` David Mosberger
2004-04-14 9:47 ` Non-Exec stack patches Jamie Lokier
2004-04-14 18:30 ` Kurt Garloff
2004-04-14 20:54 ` Jeff Dike
2004-04-14 18:35 ` Kurt Garloff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16509.25006.96933.584153@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=akpm@osdl.org \
--cc=davidm@hpl.hp.com \
--cc=garloff@suse.de \
--cc=jamie@shareable.org \
--cc=linux-ia64@linuxia64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®