mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liu Xinpeng <liuxp11@chinatelecom.cn>
To: wim@linux-watchdog.org, linux@roeck-us.net, tzungbi@kernel.org
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	Liu Xinpeng <liuxp11@chinatelecom.cn>
Subject: [PATCH v4 4/4] watchdog: iTCO_wdg: Make code more clearly with macro definition
Date: Tue, 26 Apr 2022 15:10:29 +0800	[thread overview]
Message-ID: <1650957029-910-5-git-send-email-liuxp11@chinatelecom.cn> (raw)
In-Reply-To: <1650957029-910-1-git-send-email-liuxp11@chinatelecom.cn>

Using SET_NOIRQ_SYSTEM_SLEEP_PM_OPS reduces redundant code.

Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
 drivers/watchdog/iTCO_wdt.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
index 3f2f4343644f..8d24cf4f4ca3 100644
--- a/drivers/watchdog/iTCO_wdt.c
+++ b/drivers/watchdog/iTCO_wdt.c
@@ -635,22 +635,18 @@ static int iTCO_wdt_resume_noirq(struct device *dev)
 
 	return 0;
 }
+#endif /* CONFIG_PM_SLEEP */
 
 static const struct dev_pm_ops iTCO_wdt_pm = {
-	.suspend_noirq = iTCO_wdt_suspend_noirq,
-	.resume_noirq = iTCO_wdt_resume_noirq,
+	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(iTCO_wdt_suspend_noirq,
+				      iTCO_wdt_resume_noirq)
 };
 
-#define ITCO_WDT_PM_OPS	(&iTCO_wdt_pm)
-#else
-#define ITCO_WDT_PM_OPS	NULL
-#endif /* CONFIG_PM_SLEEP */
-
 static struct platform_driver iTCO_wdt_driver = {
 	.probe          = iTCO_wdt_probe,
 	.driver         = {
 		.name   = DRV_NAME,
-		.pm     = ITCO_WDT_PM_OPS,
+		.pm     = &iTCO_wdt_pm,
 	},
 };
 
-- 
2.23.0


  parent reply	other threads:[~2022-04-26  7:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26  7:10 [PATCH v4 0/4] Some impovements about watchdog Liu Xinpeng
2022-04-26  7:10 ` [PATCH v4 1/4] watchdog: wdat_wdg: Using the existed function to check parameter timeout Liu Xinpeng
2022-04-26  8:05   ` Guenter Roeck
2022-04-26  7:10 ` [PATCH v4 2/4] watchdog: wdat_wdg: Stop watchdog when rebooting the system Liu Xinpeng
2022-04-26  7:10 ` [PATCH v4 3/4] watchdog: wdat_wdg: Stop watchdog when uninstalling module Liu Xinpeng
2022-04-26  7:10 ` Liu Xinpeng [this message]
2022-04-26  8:01   ` [PATCH v4 4/4] watchdog: iTCO_wdg: Make code more clearly with macro definition Guenter Roeck
     [not found]     ` <2022042616173226700718@chinatelecom.cn>
2022-04-26  8:27       ` Guenter Roeck
2022-04-26  8:12   ` Guenter Roeck
     [not found]     ` <2022042616273282549226@chinatelecom.cn>
2022-04-26  8:35       ` Guenter Roeck
  -- strict thread matches above, loose matches on Subject: below --
2022-04-26  7:03 [PATCH v3 0/4] Some impovements about watchdog Liu Xinpeng
2022-04-26  7:03 ` [PATCH v4 4/4] watchdog: iTCO_wdg: Make code more clearly with macro definition Liu Xinpeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1650957029-910-5-git-send-email-liuxp11@chinatelecom.cn \
    --to=liuxp11@chinatelecom.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=tzungbi@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®