From: Jens Axboe <axboe@kernel.dk>
To: tj@kernel.org
Cc: linux-block@vger.kernel.org, saravanand@fb.com,
chris.obbard@collabora.com, kernel-team@fb.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH block-5.18] Revert "block: inherit request start time from bio for BLK_CGROUP"
Date: Wed, 27 Apr 2022 13:51:38 -0600 [thread overview]
Message-ID: <165108909873.140853.15966713411862913960.b4-ty@kernel.dk> (raw)
In-Reply-To: <YmmeOLfo5lzc+8yI@slm.duckdns.org>
On Wed, 27 Apr 2022 09:49:12 -1000, Tejun Heo wrote:
> This reverts commit 0006707723233cb2a9a23ca19fc3d0864835704c. It has a
> couple problems:
>
> * bio_issue_time() is stored in bio->bi_issue truncated to 51 bits. This
> overflows in slightly over 26 days. Setting rq->io_start_time_ns with it
> means that io duration calculation would yield >26days after 26 days of
> uptime. This, for example, confuses kyber making it cause high IO
> latencies.
>
> [...]
Applied, thanks!
[1/1] Revert "block: inherit request start time from bio for BLK_CGROUP"
commit: 4cddeacad6d4b23493a108d0705e7d2ab89ba5a3
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-04-27 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 19:49 Tejun Heo
2022-04-27 19:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165108909873.140853.15966713411862913960.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=chris.obbard@collabora.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanand@fb.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®