From: Paul Mackerras <paulus@samba.org>
To: Keith Owens <kaos@sgi.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks
Date: Tue, 27 Apr 2004 21:36:48 +1000 [thread overview]
Message-ID: <16526.17872.872703.799153@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <6087.1083051952@kao2.melbourne.sgi.com>
Keith Owens writes:
> On Tue, 27 Apr 2004 16:54:11 +1000,
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >Looks good, except as paulus noted that using 0 for flags in the
> >_raw_spin_lock() case is wrong, since 0 is a valid flags value
> >for some archs that could mean anything...
>
> 0 is valid for ia64, which is the only architecture that currently
> defines __HAVE_ARCH_RAW_SPIN_LOCK_FLAGS. If other architectures want
> to define __HAVE_ARCH_RAW_SPIN_LOCK_FLAGS and they need a different
> flag value to indicate 'no flags available' then the 0 can be changed
> to an arch defined value. Worry about that if it ever occurs.
I was just thinking yesterday that it would be good to reenable
interrupts during spin_lock_irq on ppc64. I am hacking on the
spinlocks for ppc64 at the moment and this looks like something worth
adding.
Why not keep _raw_spin_lock as it is and only use _raw_spin_lock_flags
in the spin_lock_irq{,save} case?
Paul.
next prev parent reply other threads:[~2004-04-27 11:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-27 1:59 Keith Owens
2004-04-27 4:49 ` Andrew Morton
2004-04-27 5:19 ` Keith Owens
2004-04-27 6:54 ` Benjamin Herrenschmidt
2004-04-27 7:45 ` Keith Owens
2004-04-27 11:36 ` Paul Mackerras [this message]
2004-04-27 12:05 ` Keith Owens
2004-04-27 12:33 ` Christoph Hellwig
2004-04-27 16:01 ` Linus Torvalds
2004-04-28 3:29 ` [patch] 2.6.6-rc3 " Keith Owens
2004-04-30 7:07 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16526.17872.872703.799153@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=benh@kernel.crashing.org \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®