From: Mikael Pettersson <mikpe@user.it.uu.se>
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH][2.6.6-rc3] gcc-3.4.0 fixes
Date: Wed, 28 Apr 2004 15:07:49 +0200 [thread overview]
Message-ID: <16527.44197.587250.992871@alkaid.it.uu.se> (raw)
This patch fixes three warnings from gcc-3.4.0 in 2.6.6-rc3:
- arch/i386/pci/pcbios.c: use of "+m" constraint
- drivers/char/ftape/: use of cast-as-lvalue
- drivers/char/ftape/: __attribute__((packed)) on something
containing only bytes
Compiles cleanly and works for me.
This isn't critical, I'll resend after 2.6.6 final if
you don't want to merge it right now.
/Mikael
diff -ruN linux-2.6.6-rc3/arch/i386/pci/pcbios.c linux-2.6.6-rc3.gcc340-fixes/arch/i386/pci/pcbios.c
--- linux-2.6.6-rc3/arch/i386/pci/pcbios.c 2003-09-09 14:22:28.000000000 +0200
+++ linux-2.6.6-rc3.gcc340-fixes/arch/i386/pci/pcbios.c 2004-04-28 12:21:00.000000000 +0200
@@ -431,11 +431,13 @@
"1:"
: "=a" (ret),
"=b" (map),
- "+m" (opt)
+ "=m" (opt)
: "0" (PCIBIOS_GET_ROUTING_OPTIONS),
"1" (0),
"D" ((long) &opt),
- "S" (&pci_indirect));
+ "S" (&pci_indirect),
+ "m" (opt)
+ : "memory");
DBG("OK ret=%d, size=%d, map=%x\n", ret, opt.size, map);
if (ret & 0xff00)
printk(KERN_ERR "PCI: Error %02x when fetching IRQ routing table.\n", (ret >> 8) & 0xff);
diff -ruN linux-2.6.6-rc3/drivers/char/ftape/lowlevel/ftape-bsm.c linux-2.6.6-rc3.gcc340-fixes/drivers/char/ftape/lowlevel/ftape-bsm.c
--- linux-2.6.6-rc3/drivers/char/ftape/lowlevel/ftape-bsm.c 2002-02-20 03:10:58.000000000 +0100
+++ linux-2.6.6-rc3.gcc340-fixes/drivers/char/ftape/lowlevel/ftape-bsm.c 2004-04-28 12:21:00.000000000 +0200
@@ -203,6 +203,7 @@
ft_format_code == fmt_1100ft) {
SectorCount *ptr = (SectorCount *)bad_sector_map;
unsigned int sector;
+ __u16 *ptr16;
while((sector = get_sector(ptr++)) != 0) {
if ((ft_format_code == fmt_big ||
@@ -218,9 +219,10 @@
}
/* Display old ftape's end-of-file marks
*/
- while ((sector = get_unaligned(((__u16*)ptr)++)) != 0) {
+ ptr16 = (__u16*)ptr;
+ while ((sector = get_unaligned(ptr16++)) != 0) {
TRACE(ft_t_noise, "Old ftape eof mark: %4d/%2d",
- sector, get_unaligned(((__u16*)ptr)++));
+ sector, get_unaligned(ptr16++));
}
} else { /* fixed size format */
for (i = ft_first_data_segment;
diff -ruN linux-2.6.6-rc3/drivers/char/ftape/lowlevel/ftape-bsm.h linux-2.6.6-rc3.gcc340-fixes/drivers/char/ftape/lowlevel/ftape-bsm.h
--- linux-2.6.6-rc3/drivers/char/ftape/lowlevel/ftape-bsm.h 2002-02-20 03:10:52.000000000 +0100
+++ linux-2.6.6-rc3.gcc340-fixes/drivers/char/ftape/lowlevel/ftape-bsm.h 2004-04-28 12:21:00.000000000 +0200
@@ -47,7 +47,7 @@
*/
typedef struct NewSectorMap {
__u8 bytes[3];
-} SectorCount __attribute__((packed));
+} SectorCount;
/*
diff -ruN linux-2.6.6-rc3/drivers/char/ftape/zftape/zftape-eof.c linux-2.6.6-rc3.gcc340-fixes/drivers/char/ftape/zftape/zftape-eof.c
--- linux-2.6.6-rc3/drivers/char/ftape/zftape/zftape-eof.c 2003-02-24 23:25:37.000000000 +0100
+++ linux-2.6.6-rc3.gcc340-fixes/drivers/char/ftape/zftape/zftape-eof.c 2004-04-28 12:21:00.000000000 +0200
@@ -123,7 +123,7 @@
while (ptr + 3 < limit) {
if (get_unaligned((__u32*)ptr)) {
- ++(__u32*)ptr;
+ ptr += sizeof(__u32);
} else {
return ptr;
}
next reply other threads:[~2004-04-28 13:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-28 13:07 Mikael Pettersson [this message]
[not found] <1PX8S-5z2-23@gated-at.bofh.it>
2004-04-29 9:30 ` Ihar 'Philips' Filipau
2004-04-29 20:46 ` Paul Wagland
2004-04-29 20:54 ` Denis Vlasenko
2004-04-29 21:35 ` Ihar 'Philips' Filipau
2004-04-29 21:46 Mikael Pettersson
2004-05-17 0:58 ` H. Peter Anvin
2004-06-01 14:52 ` Mikael Pettersson
2004-06-01 15:09 ` William Lee Irwin III
2004-06-01 15:35 ` Mikael Pettersson
2004-06-01 15:38 ` Andreas Schwab
2004-06-01 17:09 ` H. Peter Anvin
2004-06-01 17:14 ` H. Peter Anvin
2004-06-01 21:47 ` Mikael Pettersson
2004-06-01 17:27 ` Linus Torvalds
2004-06-01 19:34 ` Chris Wedgwood
2004-07-16 4:28 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16527.44197.587250.992871@alkaid.it.uu.se \
--to=mikpe@user.it.uu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®