From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F9AC43334 for ; Fri, 10 Jun 2022 17:00:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346223AbiFJRA0 (ORCPT ); Fri, 10 Jun 2022 13:00:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344239AbiFJRAM (ORCPT ); Fri, 10 Jun 2022 13:00:12 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6D31738BF0 for ; Fri, 10 Jun 2022 09:59:43 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 566B012FC; Fri, 10 Jun 2022 09:59:43 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 83FE23F766; Fri, 10 Jun 2022 09:59:42 -0700 (PDT) From: Sudeep Holla To: linux-kernel@vger.kernel.org, Cristian Marussi , linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla Subject: Re: [PATCH 1/3] firmware: arm_scmi: Review BASE protocol string-buffers sizes Date: Fri, 10 Jun 2022 17:59:31 +0100 Message-Id: <165488021406.462190.1740470149843111137.b4-ty@arm.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220608095530.497879-1-cristian.marussi@arm.com> References: <20220608095530.497879-1-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Jun 2022 10:55:28 +0100, Cristian Marussi wrote: > SCMI Base protocol agent_name/vendor_id/sub_vendor_id are defined by the > specification as NULL-terminated ASCII strings up to 16-bytes in length. > > The underlying buffers and message descriptors are currently bigger than > needed; resize them to fit only the strictly needed 16 bytes. > > While at that, convert Base protocol strings handling routines to use the > preferred strscpy. > > [...] Applied to sudeep.holla/linux (for-next/scmi), thanks! [1/3] firmware: arm_scmi: Review BASE protocol string-buffers sizes https://git.kernel.org/sudeep.holla/c/4314f9f4f8 [2/3] firmware: arm_scmi: Fix SENSOR_AXIS_NAME_GET behaviour when unsupported https://git.kernel.org/sudeep.holla/c/8e60294c80 [3/3] firmware: arm_scmi: Use preferred strscpy to handle strings Merged in 1/3 to avoid any possible bisection issues, since they both deal with the same issue. -- Regards, Sudeep