From: Mark Brown <broonie@kernel.org>
To: conor.dooley@microchip.com
Cc: linux-riscv@lists.infradead.org, linux-spi@vger.kernel.org,
dan.carpenter@oracle.com, daire.mcnamara@microchip.com,
lewis.hanly@microchip.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] spi: microchip-core: fix passing zero to PTR_ERR warning
Date: Thu, 16 Jun 2022 12:42:47 +0100 [thread overview]
Message-ID: <165537976740.874420.15190272235131912340.b4-ty@kernel.org> (raw)
In-Reply-To: <20220615142028.2991915-1-conor.dooley@microchip.com>
On Wed, 15 Jun 2022 15:20:29 +0100, Conor Dooley wrote:
> It is possible that the error case for devm_clk_get() returns NULL,
> in which case zero will be passed to PTR_ERR() as shown by the Smatch
> static checker warning:
> drivers/spi/spi-microchip-core.c:557 mchp_corespi_probe()
> warn: passing zero to 'PTR_ERR'
>
> Remove the NULL check and carry on with a dummy clock in case of an
> error. To avoid a potential div zero, abort calculating clkgen if
> clk_get_rate(spi->clk) is zero.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: microchip-core: fix passing zero to PTR_ERR warning
commit: 2081ad1467469b649fc9f9226b235977a7bf9402
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2022-06-16 11:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 14:20 Conor Dooley
2022-06-16 11:42 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165537976740.874420.15190272235131912340.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=dan.carpenter@oracle.com \
--cc=lewis.hanly@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®