From: Paul Mackerras <paulus@samba.org>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: David Gibson <david@gibson.dropbear.id.au>,
Andrew Morton <akpm@osdl.org>, Anton Blanchard <anton@samba.org>,
linux-kernel@vger.kernel.org, linuxppc64-dev@lists.linuxppc.org
Subject: Re: [PPC64] Remove silly debug path from get_vsid()
Date: Fri, 28 May 2004 14:53:40 +1000 [thread overview]
Message-ID: <16566.50644.847967.850463@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20040528035537.GT2603@schnapps.adilger.int>
Andreas Dilger writes:
> so presumably if you don't select CONFIG_PPCDBG it is also a no-op unless
> the compiler is broken and doesn't optimize away "if (0)" stanzas. The
> original construct gives you the option to enable this particular debugging
> at runtime (without necessarily enabling all debugging at one time) if wanted.
And the effect of suddenly changing your VSID calculation algorithm in
mid-stream is pretty catastrophic. There is no sensible reason
wanting to be able to turn this on and off at runtime. This is not
just some extra checking.
Paul.
prev parent reply other threads:[~2004-05-28 4:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-28 3:16 David Gibson
2004-05-28 3:55 ` Andreas Dilger
2004-05-28 4:53 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16566.50644.847967.850463@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=adilger@clusterfs.com \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®