From: Pierre Gondois <pierre.gondois@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, Ionela.Voinescu@arm.com,
dietmar.eggemann@arm.com, sudeep.holla@arm.com,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>,
linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
devel@acpica.org
Subject: Re: [PATCH v2 1/5] ACPI: CPPC: Check _OSC for flexible address space
Date: Wed, 18 May 2022 12:34:24 +0200 [thread overview]
Message-ID: <16566ef8-15d3-bf1b-37f2-c0b94b0493bc@arm.com> (raw)
In-Reply-To: <20220518094243.6oxbdmf226jvqoef@viresh-thinkpad>
On 5/18/22 11:42, Viresh Kumar wrote:
> On 18-05-22, 11:08, Pierre Gondois wrote:
>> ACPI 6.2 Section 6.2.11.2 'Platform-Wide OSPM Capabilities':
>> Starting with ACPI Specification 6.2, all _CPC registers can be in
>> PCC, System Memory, System IO, or Functional Fixed Hardware address
>> spaces. OSPM support for this more flexible register space scheme is
>> indicated by the “Flexible Address Space for CPPC Registers” _OSC bit
>>
>> Otherwise (cf ACPI 6.1, s8.4.7.1.1.X), _CPC registers must be in:
>> - PCC or Functional Fixed Hardware address space if defined
>> - SystemMemory address space (NULL register) if not defined
>>
>> Add the corresponding _OSC bit and check it when parsing _CPC objects.
>>
>> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
>> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>> drivers/acpi/bus.c | 18 ++++++++++++++++++
>> drivers/acpi/cppc_acpi.c | 9 +++++++++
>> include/linux/acpi.h | 2 ++
>> 3 files changed, 29 insertions(+)
>
> It would be much useful to get a cover letter for this series with
> what you have changed since the previous version. It is almost
> impossible to find that out otherwise.
>
Yes indeed, sorry for that, the changelog is:
v2:
[1/5] ACPI: CPPC: Check _OSC for flexible address space
- Renamed OSC_SB_CPC_FLEXIBLE_ADR_SP to OSC_SB_CPC_FLEXIBLE_ADR_SPACE
[3/5] ACPI: CPPC: Assume no transition latency if no PCCT
and
[4/5] cpufreq: CPPC: Enable fast_switch
- Renamed CPC_IN_SIO to CPC_IN_SYSTEM_IO
- Renamed CPC_IN_SM to CPC_IN_SYSTEM_MEMORY
or do you prefer to have the serie re-submitted ?
Regards,
Pierre
next prev parent reply other threads:[~2022-05-18 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 9:08 Pierre Gondois
2022-05-18 9:08 ` [PATCH v2 2/5] ACPI: bus: Set CPPC _OSC bits for all and when CPPC_LIB is supported Pierre Gondois
2022-05-18 9:08 ` [PATCH v2 3/5] ACPI: CPPC: Assume no transition latency if no PCCT Pierre Gondois
2022-05-18 9:09 ` [PATCH v2 4/5] cpufreq: CPPC: Enable fast_switch Pierre Gondois
2022-05-18 9:09 ` [PATCH v2 5/5] cpufreq: CPPC: Enable dvfs_possible_from_any_cpu Pierre Gondois
2022-05-18 9:42 ` [PATCH v2 1/5] ACPI: CPPC: Check _OSC for flexible address space Viresh Kumar
2022-05-18 10:34 ` Pierre Gondois [this message]
2022-05-18 12:28 ` Viresh Kumar
2022-05-19 17:47 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16566ef8-15d3-bf1b-37f2-c0b94b0493bc@arm.com \
--to=pierre.gondois@arm.com \
--cc=Ionela.Voinescu@arm.com \
--cc=devel@acpica.org \
--cc=dietmar.eggemann@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®