mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ZhangZhiJie <zhangzhijie@bosc.ac.cn>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	jeff@jeffgeerling.com, wangran@bosc.ac.cn, zhangjian@bosc.ac.cn,
	daniel@ffwll.ch, rodrigo.vivi@intel.com,
	joonas.lahtinen@linux.intel.com, tursulin@ursulin.net,
	airlied@gmail.com, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, guoyaxing@bosc.ac.cn
Subject: Re: [PATCH v2] i915: Support Intel GPU porting on any non-x86 system.
Date: Tue, 25 Nov 2025 17:55:34 +0800	[thread overview]
Message-ID: <1657dccb-3d03-420a-9ffa-5601ae212fd9@bosc.ac.cn> (raw)
In-Reply-To: <bac7a05b799309fe2c269232e70e82f86a8e2811@intel.com>



On 2025/11/24 20:24, Jani Nikula wrote:
> On Mon, 24 Nov 2025, zhangzhijie <zhangzhijie@bosc.ac.cn> wrote:
>> inb/outb speccial wire not support on other ARCH.
>> Should detect whether arch platform support or not.
> 
> Seems to me it inb/outb depend on CONFIG_HAS_IOPORT. Which arch are you
> talking about specifically?

riscv , has CONFIG_HAS_IOPORT.  is using for serial, GPIO., etc.

Thanks.
BR.
ZhiJie
> 
>> Signed-off-by: zhangzhijie <zhangzhijie@bosc.ac.cn>
>> ---
>>   drivers/gpu/drm/i915/display/intel_vga.c | 27 ++++++++++++++++++------
>>   1 file changed, 20 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c
>> index 6e125564db34..d5d6c4ba6434 100644
>> --- a/drivers/gpu/drm/i915/display/intel_vga.c
>> +++ b/drivers/gpu/drm/i915/display/intel_vga.c
>> @@ -41,6 +41,15 @@ static bool has_vga_pipe_sel(struct intel_display *display)
>>   	return DISPLAY_VER(display) < 7;
>>   }
>>   
>> +static bool intel_arch_support_vga_pm(struct intel_display *display)
>> +{
>> +#if defined(CONFIG_X86) || defined(CONFIG_X86_64)
>> +	return true;
>> +#else
>> +	return false;
>> +#endif
>> +}
>> +
>>   /* Disable the VGA plane that we never use */
>>   void intel_vga_disable(struct intel_display *display)
>>   {
>> @@ -66,11 +75,13 @@ void intel_vga_disable(struct intel_display *display)
>>   
>>   	/* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */
>>   	vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO);
>> -	outb(0x01, VGA_SEQ_I);
>> -	sr1 = inb(VGA_SEQ_D);
>> -	outb(sr1 | VGA_SR01_SCREEN_OFF, VGA_SEQ_D);
>> -	vga_put(pdev, VGA_RSRC_LEGACY_IO);
>> -	udelay(300);
>> +	if (likely(intel_arch_support_vga_pm(display))) {
> 
> As a rule of thumb, please do not use likely/unlikely, at all.
> 
> Here, intel_arch_support_vga_pm() is evaluated at build time, and the
> likely has no functional value, only dubious documentation value.
> 
>> +		outb(0x01, VGA_SEQ_I);
>> +		sr1 = inb(VGA_SEQ_D);
>> +		outb(sr1 | VGA_SR01_SCREEN_OFF, VGA_SEQ_D);
>> +		vga_put(pdev, VGA_RSRC_LEGACY_IO);
> 
> Both or neither get/put need to be inside the branch. Now you only get,
> never put, on non-x86.
> 
> BR,
> Jani.
> 
>> +		udelay(300);
>> +	}
>>   
>>   	intel_de_write(display, vga_reg, VGA_DISP_DISABLE);
>>   	intel_de_posting_read(display, vga_reg);
>> @@ -91,8 +102,10 @@ void intel_vga_reset_io_mem(struct intel_display *display)
>>   	 * and error messages.
>>   	 */
>>   	vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO);
>> -	outb(inb(VGA_MIS_R), VGA_MIS_W);
>> -	vga_put(pdev, VGA_RSRC_LEGACY_IO);
>> +	if (likely(intel_arch_support_vga_pm(display))) {
>> +		outb(inb(VGA_MIS_R), VGA_MIS_W);
>> +		vga_put(pdev, VGA_RSRC_LEGACY_IO);
>> +	}
>>   }
>>   
>>   int intel_vga_register(struct intel_display *display)
> 


  reply	other threads:[~2025-11-25  9:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24  6:56 zhangzhijie
2025-11-24 12:24 ` Jani Nikula
2025-11-25  9:55   ` ZhangZhiJie [this message]
2025-11-25 10:13     ` Jani Nikula
2025-11-25 10:20       ` ZhangZhiJie
2025-11-25 21:54         ` Lucas De Marchi
2025-11-26  1:39           ` ZhangZhiJie
2025-11-25 13:18 ` Simon Richter
  -- strict thread matches above, loose matches on Subject: below --
2025-11-24  6:56 zhangzhijie
2025-11-24 21:05 ` Ville Syrjälä
2025-11-25  3:31   ` ZhangZhiJie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1657dccb-3d03-420a-9ffa-5601ae212fd9@bosc.ac.cn \
    --to=zhangzhijie@bosc.ac.cn \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=guoyaxing@bosc.ac.cn \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jeff@jeffgeerling.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tursulin@ursulin.net \
    --cc=wangran@bosc.ac.cn \
    --cc=zhangjian@bosc.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®