From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934876AbeAKPxn (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 11 Jan 2018 10:53:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37732 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932223AbeAKPxl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 Jan 2018 10:53:41 -0500
Subject: Re: [PATCH] x86: kvm: propagate register_shrinker return code
To: Arnd Bergmann <arnd@arndb.de>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        David Hildenbrand <david@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Junaid Shahid <junaids@google.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20180110162730.400337-1-arnd@arndb.de>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <1658686a-1f40-7e7e-e1b0-70af6908a9d0@redhat.com>
Date: Thu, 11 Jan 2018 16:53:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20180110162730.400337-1-arnd@arndb.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 11 Jan 2018 15:53:41 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 10/01/2018 17:26, Arnd Bergmann wrote:
> Patch "mm,vmscan: mark register_shrinker() as __must_check" is
> queued for 4.16 in linux-mm and adds a warning about the unchecked
> call to register_shrinker:
> 
> arch/x86/kvm/mmu.c:5485:2: warning: ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result]
> 
> This changes the kvm_mmu_module_init() function to fail itself
> when the call to register_shrinker fails.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/x86/kvm/mmu.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 89da688784fa..765c8e9df5d9 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -5465,30 +5465,34 @@ static void mmu_destroy_caches(void)
>  
>  int kvm_mmu_module_init(void)
>  {
> +	int ret = -ENOMEM;
> +
>  	kvm_mmu_clear_all_pte_masks();
>  
>  	pte_list_desc_cache = kmem_cache_create("pte_list_desc",
>  					    sizeof(struct pte_list_desc),
>  					    0, SLAB_ACCOUNT, NULL);
>  	if (!pte_list_desc_cache)
> -		goto nomem;
> +		goto out;
>  
>  	mmu_page_header_cache = kmem_cache_create("kvm_mmu_page_header",
>  						  sizeof(struct kvm_mmu_page),
>  						  0, SLAB_ACCOUNT, NULL);
>  	if (!mmu_page_header_cache)
> -		goto nomem;
> +		goto out;
>  
>  	if (percpu_counter_init(&kvm_total_used_mmu_pages, 0, GFP_KERNEL))
> -		goto nomem;
> +		goto out;
>  
> -	register_shrinker(&mmu_shrinker);
> +	ret = register_shrinker(&mmu_shrinker);
> +	if (ret)
> +		goto out;
>  
>  	return 0;
>  
> -nomem:
> +out:
>  	mmu_destroy_caches();
> -	return -ENOMEM;
> +	return ret;
>  }
>  
>  /*
> 

Queued, thanks.

Paolo